New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

we can import `fs/promises` since it's only used in a node environment. #1062

Merged

Janther merged 2 commits into v2 from import-fs-promises

Nov 14, 2024

Contributor

Janther commented Nov 3, 2024

With this, we don't need custom code for node environment and the browser never uses this module


          we can import fs/promises since it's only used in a node environment.

7319f63

Janther requested a review from fvictorio

November 3, 2024 07:28


          adding the configuration for the test app as well

afc1c89

fvictorio approved these changes

View reviewed changes

Janther merged commit 7e34f9e into v2

7 checks passed

Janther deleted the import-fs-promises branch

November 14, 2024 20:30

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet