-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Presto_Elasticsearch_connector #14
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks very good! I have some suggestions for formatting, but I thought your draft was well-organized and structured. When you revise this I'll test it. Thanks!
## Note: | ||
This tutorial was tested with Elasticsearch Version: 8.8.1 | ||
|
||
Run the Elasticsearch with the following command |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggest "Run Elasticsearch with the following command" or maybe "To run Elasticsearch, run the following command
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please provide a docker compose example.
|
||
|
||
$ bin/elasticsearch | ||
[2023-06-21T11:14:25,557][INFO ][o.e.n.Node ] [ip-172-31-18-24.ap-south-1.compute.internal] version[8.8.1], pid[6057], build[tar/f8edfccba429b6477927a7c1ce1bc6729521305e/2023-06-05T21:32:25.188464208Z], OS[Linux/6.1.29-50.88.amzn2023.x86_64/amd64], JVM[Oracle Corporation/OpenJDK 64-Bit Server VM/20.0.1/20.0.1+9-29] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If this is the initial output of the command bin/elasticsearch, suggest introducing this with something like "The output should be similar to the following", or some other description.
Run the Elasticsearch with the following command | ||
|
||
|
||
$ bin/elasticsearch |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider formatting commands the user must enter with a pair of ` before and after, like this: bin/elasticsearch
. Consider this formatting throughout the tutorial to mark commands.
|
||
It should show you an output like: | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider formatting this as a code block.
|
||
|
||
## Adding data to index | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Introduce this command and describe what it will do: add data for (what?) into the index table?
Does the index table exist before this command is run? If not, maybe describe it as "Create the index table and..."
Also maybe describe what the output, if any, at the command line is for the successful command.
|
||
Elasticsearch Connector Configuration# | ||
|
||
To configure the Elasticsearch connector, create a catalog properties file etc/catalog/elasticsearch.properties with the following contents, replacing the properties as appropriate: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggest formatting "etc/catalog/elasticsearch.properties" as inline code.
|
||
$ ./presto --server localhost:8080 --catalog elasticsearch --schema default | ||
|
||
presto> show tables in elasticsearch.default; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Explain what the user is doing. "At the Presto prompt, run the following command:
- Suggest formatting the command on the next line as code
$ ./presto --server localhost:8080 --catalog elasticsearch --schema default | ||
|
||
presto> show tables in elasticsearch.default; | ||
Table |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggest code block
Splits: 19 total, 19 done (100.00%) | ||
[Latency: client-side: 249ms, server-side: 240ms] [2 rows, 53B] [8 rows/s, 220B/s] | ||
|
||
presto> select * from elasticsearch.default.samples; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Susggest the same as above: tell the user what they are doing, and where (the Presto prompt), format the command as code, and format the following output as a code block.
|
||
The Presto CLI provides a terminal-based interactive shell for running queries. The CLI is a self-executing JAR file, which means it acts like a normal UNIX executable. | ||
|
||
Download presto-cli-0.281-executable.jar, rename it to presto, make it executable with chmod +x, then run it: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Download presto-cli-0.281-executable.jar, rename it to presto, make it executable with chmod +x, then run it: | |
Download :maven_download:`cli`. | |
Rename the JAR file to ``presto`` with the following command: | |
mv :maven_download:`cli` presto | |
Use ``chmod +x`` to make the renamed file executable: | |
chmod +x presto |
No description provided.