-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to Airbase 61 #7310
Update to Airbase 61 #7310
Conversation
What about the issue with cassandra (update of guava)? As I see there are two solutions: I think we need to choose an approach and solve this issue as it lasts for so long and it causing that we are unable to upgrade airbase at all. I vote for B. |
We should shade Guava. Changing how testing works is a huge project and I'm not sure it's even possible without losing IDE support.
|
Shading could be also a huge project and what is more, if we do not change our approach we could hit similar issue in the near feature once again with the other library. |
Another problem is that the Cassandra plugin depends on Airlift which uses the latest Guava. So we'd need to keep it on an old version or remove Airlift.
Instead of shading, we could fork the project and publish a fork with the minor changes to update Guava. This is a temporary solution until they update (and hopefully learn their lesson so this isn't a problem for future Guava versions).
|
Then... should we only use it for cassandra connector tests or generally for cassandra connector? There are also some issues with hive:
But as I understand hive is already shaded (forked) so we would need to handle guava there as well. |
We'd need to fork any artifacts that aren't compatible.
I'm aware of the hive-dwrf problem and will release a patched version soon. It is a separate artifact and comes from here: https://github.com/facebookarchive/hive-dwrf
|
Fix for DWRF: facebookarchive/hive-dwrf#24 |
@electrum Thank you for taking care of this! |
This includes the commits from #6995