Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Airbase 61 #7310

Merged
merged 6 commits into from
Feb 17, 2017
Merged

Update to Airbase 61 #7310

merged 6 commits into from
Feb 17, 2017

Conversation

electrum
Copy link
Contributor

@electrum electrum commented Feb 6, 2017

This includes the commits from #6995

@kokosing
Copy link
Contributor

kokosing commented Feb 7, 2017

What about the issue with cassandra (update of guava)?

As I see there are two solutions:
a. shade guava - #6995 (comment)
b. load connector in tests in isolated classloader - #6995 (comment)

I think we need to choose an approach and solve this issue as it lasts for so long and it causing that we are unable to upgrade airbase at all.

I vote for B.

@kokosing kokosing mentioned this pull request Feb 7, 2017
@electrum
Copy link
Contributor Author

electrum commented Feb 7, 2017 via email

@kokosing
Copy link
Contributor

kokosing commented Feb 7, 2017

Shading could be also a huge project and what is more, if we do not change our approach we could hit similar issue in the near feature once again with the other library.

@electrum
Copy link
Contributor Author

electrum commented Feb 7, 2017 via email

@kokosing
Copy link
Contributor

kokosing commented Feb 8, 2017

Instead of shading, we could fork the project and publish a fork with the minor changes to update Guava. This is a temporary solution until they update (and hopefully learn their lesson so this isn't a problem for future Guava versions).

Then... should we only use it for cassandra connector tests or generally for cassandra connector?

There are also some issues with hive:

java.lang.NoClassDefFoundError: com/google/common/io/InputSupplier
	at com.facebook.presto.hive.TestHiveFileFormats.testDwrf(TestHiveFileFormats.java:467)
Caused by: java.lang.ClassNotFoundException: com.google.common.io.InputSupplier
	at com.facebook.presto.hive.TestHiveFileFormats.testDwrf(TestHiveFileFormats.java:467)

But as I understand hive is already shaded (forked) so we would need to handle guava there as well.

@electrum
Copy link
Contributor Author

electrum commented Feb 8, 2017 via email

@electrum
Copy link
Contributor Author

Fix for DWRF: facebookarchive/hive-dwrf#24

@electrum electrum closed this Feb 17, 2017
@electrum electrum deleted the airbase branch February 17, 2017 00:03
@electrum electrum merged commit 4b3f456 into prestodb:master Feb 17, 2017
@kokosing
Copy link
Contributor

@electrum Thank you for taking care of this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants