Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Pdocker build #23809

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix Pdocker build #23809

wants to merge 1 commit into from

Conversation

Joe-Abraham
Copy link
Contributor

@Joe-Abraham Joe-Abraham commented Oct 11, 2024 •
edited
Loading

@Joe-Abraham Joe-Abraham marked this pull request as ready for review October 11, 2024 13:55
@Joe-Abraham Joe-Abraham requested a review from a team as a code owner October 11, 2024 13:55
@Joe-Abraham
Copy link
Contributor Author

@tdcmeehan, Can you please review the changes?

tdcmeehan
tdcmeehan reviewed Oct 11, 2024
View reviewed changes
presto-native-execution/pom.xml
<argument>
<![CDATA[
docker build -t "presto-native-dependency:latest" \
--build-arg BUILD_TYPE="Release" \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any way to preserve the original way of going about this, with the properties in the POM?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tdcmeehan tdcmeehan tdcmeehan left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Joe-Abraham @tdcmeehan