[native] Enhance CSV Parsing in ContainerQueryRunner to Use MaterializedResult #23382
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Joe-Abraham
force-pushed
the
parse_csv
branch
2 times, most recently
from
73f86c4
to
bcd6501
Compare
Joe-Abraham
changed the title
|
@tdcmeehan Can you please have a look? |
tdcmeehan
reviewed
Aug 5, 2024
...tive-execution/src/test/java/com/facebook/presto/nativeworker/ContainerQueryRunnerUtils.java
Outdated
Show resolved
Hide resolved
tdcmeehan
requested changes
Aug 6, 2024
...tive-execution/src/test/java/com/facebook/presto/nativeworker/ContainerQueryRunnerUtils.java
Outdated
Show resolved
Hide resolved
tdcmeehan
reviewed
Aug 7, 2024
...tive-execution/src/test/java/com/facebook/presto/nativeworker/ContainerQueryRunnerUtils.java
Outdated
Show resolved
Hide resolved
tdcmeehan
approved these changes
Aug 7, 2024
Joe-Abraham
force-pushed
the
parse_csv
branch
2 times, most recently
from
f45d279
to
5493c48
Compare
34 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #23086