Update docker compose scripts for docker compose v2 #23360
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rschlussel
force-pushed
the
compose-v2
branch
2 times, most recently
from
207bca3 to
2f9cabf
Compare
rschlussel
requested review from
steveburnett,
a team and
shrinidhijoshi
as code owners
rschlussel
changed the title
steveburnett
requested changes
Aug 1, 2024
presto-product-tests/README.md
Outdated
| @@ -29,15 +29,15 @@ broken. | |||
| wget -qO- https://get.docker.com/ | sh | |||
| ``` | |||
|
|
|||
| * [`docker-compose >= 1.8.1`](https://docs.docker.com/compose/install/) | |||
| * [`docker compose >= 2.3.4](https://docs.docker.com/compose/install/) | |||
There was a problem hiding this comment.
Suggested change
| * [`docker compose >= 2.3.4](https://docs.docker.com/compose/install/) | |
| * [`docker compose >= 2.3.4`](https://docs.docker.com/compose/install/) |
ZacBlanco
previously approved these changes
Aug 1, 2024
Update docker compose scripts for docker compose v2, as legacy docker-compose v1 is no longer supported for github actions.
tdcmeehan
approved these changes
Aug 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update docker compose scripts for docker compose v2, as legacy docker-compose v1 is no longer supported for github actions. There is a migration guide here https://docs.docker.com/compose/migrate/. The changes here are
docker-composetodocker compose.Motivation and Context
Fixes #22413
Github is removing docker compose v1 (the python based docker-compose command) from their github actions runners, so we need to upgrade to use docker compose v2. Without this change, tests that run on the new runners fail with "docker-compose: command not found". The removal of docker compose v1 began on July 29th and is expected to take 3-4 days, so we can expect to be fully blocked by this issue imminently actions/runner-images#9692.
Impact
Let's our tests run on images that only have docker compose v2
Test Plan
CI
Contributor checklist
Release Notes
Please follow release notes guidelines and fill in the release notes below.