-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a native function namespace manager #23358
Draft
pdabre12
wants to merge
16
commits into
prestodb:master
Choose a base branch
from
pdabre12:native-function-namespace-manager
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Add a native function namespace manager #23358
pdabre12
wants to merge
16
commits into
prestodb:master
from
pdabre12:native-function-namespace-manager
+5,276
−375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
pdabre12
force-pushed
the
native-function-namespace-manager
branch
from
August 13, 2024 23:37
49d3b9d
to
5ed5a18
Compare
pdabre12
force-pushed
the
native-function-namespace-manager
branch
2 times, most recently
from
August 17, 2024 00:06
bcb09bc
to
ce7ca4b
Compare
steveburnett
previously approved these changes
Sep 10, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! (docs)
Pull branch, new local doc build, the doc looks good. Thanks!
pdabre12
force-pushed
the
native-function-namespace-manager
branch
from
September 13, 2024 23:03
4d00991
to
c3ed29f
Compare
pdabre12
changed the title
[WIP] Native function namespace manager
[WIP] Add a native function namespace manager
Sep 13, 2024
steveburnett
previously approved these changes
Sep 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! (docs)
Pull updated branch, new local doc build, doc looks good. Thanks!
pdabre12
force-pushed
the
native-function-namespace-manager
branch
from
September 27, 2024 00:48
c3ed29f
to
3fde055
Compare
Co-authored-by: Tim Meehan <[email protected]>
pdabre12
force-pushed
the
native-function-namespace-manager
branch
from
September 27, 2024 05:55
3fde055
to
ebfa361
Compare
pdabre12
changed the title
[WIP] Add a native function namespace manager
Add a native function namespace manager
Sep 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds the native function namespace manager
Motivation and Context
To help resolve #23000
Impact
Test Plan
Unit and end-to-end tests. More comprehensive end-to-end tests will be written in the future.
Contributor checklist
Release Notes
Please follow release notes guidelines and fill in the release notes below.
If release note is NOT required, use: