[Native] Introduce functional native test framework using TestContainers #23094

Joe-Abraham · 2024-06-27T06:28:20Z

Resolves: #23086

== NO RELEASE NOTE ==

steveburnett

LGTM! (docs)

tdcmeehan · 2024-07-02T20:44:36Z

This looks good, but actually most of the expressions in this query runner will be evaluated by the coordinator. Would it be possible to add TPCH data and relevant tests?

Joe-Abraham · 2024-07-08T10:44:56Z

@tdcmeehan We have added a few relevant tests with tables using the TPCH connector. Can you please have a look?

...to-native-execution/src/test/java/com/facebook/presto/nativeworker/ContainerQueryRunner.java

...xecution/src/test/java/com/facebook/presto/nativeworker/TestPrestoContainerBasicQueries.java

...to-native-execution/src/test/java/com/facebook/presto/nativeworker/ContainerQueryRunner.java

...tive-execution/src/test/java/com/facebook/presto/nativeworker/ContainerQueryRunnerUtils.java

aditi-pandit

Thanks @Joe-Abraham. Have couple of comments.

...to-tests/src/main/java/com/facebook/presto/tests/AbstractTestNativeTpchConnectorQueries.java

...xecution/src/test/java/com/facebook/presto/nativeworker/TestPrestoContainerBasicQueries.java

...to-native-execution/src/test/java/com/facebook/presto/nativeworker/ContainerQueryRunner.java

...tive-execution/src/test/java/com/facebook/presto/nativeworker/ContainerQueryRunnerUtils.java

presto-native-execution/pom.xml

elharo · 2024-07-25T12:00:45Z

...to-native-execution/src/test/java/com/facebook/presto/nativeworker/ContainerQueryRunner.java

+            TimeUnit.SECONDS.sleep(5);
+        }
+        catch (InterruptedException e) {
+            throw new RuntimeException(e);


or just continue on?

elharo · 2024-07-25T12:02:00Z

...to-native-execution/src/test/java/com/facebook/presto/nativeworker/ContainerQueryRunner.java

+            execResult = coordinator.execInContainer(command);
+        }
+        catch (IOException e) {
+            fail("Presto CLI failed with error message: " + e.getMessage());


It's clearer to the end user to let the exception bubble up and fail the test than convert it into a fail call.

@Override public MaterializedResult execute(Session session, String sql) { ... }

Can we add exceptions to an override method? If so, aren't we required to edit its base class and the other children of the parent class?

I think this will also introduce many changes in com/facebook/presto/sql/query/QueryAssertions.java wherever the execute gets called.

...to-native-execution/src/test/java/com/facebook/presto/nativeworker/ContainerQueryRunner.java

...tive-execution/src/test/java/com/facebook/presto/nativeworker/ContainerQueryRunnerUtils.java

elharo · 2024-07-25T12:07:58Z

...to-tests/src/main/java/com/facebook/presto/tests/AbstractTestNativeTpchConnectorQueries.java

+        extends AbstractTestQueryFramework
+{
+    @Test
+    public void testTpchTinyTables()


use a data provider to break this up into tests that an pass and fail independently.

tdcmeehan

Just a couple of nits, otherwise LGTM

tdcmeehan · 2024-07-31T13:43:58Z

...to-native-execution/src/test/java/com/facebook/presto/nativeworker/ContainerQueryRunner.java

+            return ContainerQueryRunnerUtils.toMaterializedResult(execResult.getStdout());
+        }
+        catch (IOException | InterruptedException e) {
+            fail("Execute failed with error message: " + e.getMessage());


Rethrow the IOException as UncheckedIOException. For InterruptedException, just rethrow as RuntimeException.

tdcmeehan · 2024-07-31T13:44:39Z

...tive-execution/src/test/java/com/facebook/presto/nativeworker/ContainerQueryRunnerUtils.java

+            return Boolean.parseBoolean(value);
+        }
+        else {
+            fail("Unsupported type: " + type);


Just throw here

Suggested change

fail("Unsupported type: " + type);

throw new UnsupportedOperationException("Unsupported type: " + type);

tdcmeehan

Two more minor nits

tdcmeehan · 2024-07-31T14:34:38Z

...to-native-execution/src/test/java/com/facebook/presto/nativeworker/ContainerQueryRunner.java

+    private final String catalog;
+    private final String schema;
+    private final int numberOfWorkers;
+    Logger logger = Logger.getLogger(ContainerQueryRunner.class.getName());


Suggested change

Logger logger = Logger.getLogger(ContainerQueryRunner.class.getName());

private static Logger logger = Logger.getLogger(ContainerQueryRunner.class.getName());

modified it

tdcmeehan · 2024-07-31T14:34:54Z

...to-native-execution/src/test/java/com/facebook/presto/nativeworker/ContainerQueryRunner.java

+        this.schema = schema;
+        this.numberOfWorkers = numberOfWorkers;
+
+        // TODO: This framework is tested only in Ubuntu x86_64, as there is no support to run the native docker images in ARM based system,


Can you create an issue for this once it's merged?

The work is in progress #23275

aditi-pandit

Lazy review. +1

Joe-Abraham requested review from steveburnett and a team as code owners June 27, 2024 06:28

Joe-Abraham requested a review from presto-oss June 27, 2024 06:28

Joe-Abraham force-pushed the containertest branch from df275f3 to 9a30dd5 Compare June 27, 2024 08:29

Joe-Abraham changed the title ~~Add ContainerQueryRunner and add Unnest test cases~~ Add ContainerQueryRunner Jun 27, 2024

Joe-Abraham marked this pull request as draft June 27, 2024 08:31

Joe-Abraham force-pushed the containertest branch from e2bd85d to 19e13fb Compare June 28, 2024 16:01

steveburnett previously approved these changes Jun 28, 2024

View reviewed changes

Joe-Abraham dismissed steveburnett’s stale review via f063488 July 1, 2024 09:04

Joe-Abraham force-pushed the containertest branch 4 times, most recently from 70a5951 to 2424368 Compare July 1, 2024 12:03

Joe-Abraham force-pushed the containertest branch 3 times, most recently from 3a65dd3 to 7174734 Compare July 8, 2024 10:34

Joe-Abraham changed the title ~~Add ContainerQueryRunner~~ Modify TestPrestoContainerBasicQueries to use AbstractTestQueryFramework Jul 8, 2024

Joe-Abraham changed the title ~~Modify TestPrestoContainerBasicQueries to use AbstractTestQueryFramework~~ Improve TestPrestoContainerBasicQueries to use AbstractTestQueryFramework Jul 8, 2024

Joe-Abraham changed the title ~~Improve TestPrestoContainerBasicQueries to use AbstractTestQueryFramework~~ Improve Container based test Jul 8, 2024

Joe-Abraham changed the title ~~Improve Container based test~~ Improve container based test Jul 8, 2024

Joe-Abraham force-pushed the containertest branch from 7174734 to fcbd763 Compare July 8, 2024 10:42

Joe-Abraham marked this pull request as ready for review July 8, 2024 10:43

Joe-Abraham force-pushed the containertest branch from fcbd763 to 308d021 Compare July 8, 2024 14:10

abevk2023 mentioned this pull request Jul 9, 2024

[Native] Add Functional Testing Framework using Testcontainers #23087

Closed

Joe-Abraham force-pushed the containertest branch from 308d021 to 0c24e6d Compare July 10, 2024 08:27

tdcmeehan requested changes Jul 10, 2024

View reviewed changes

Joe-Abraham force-pushed the containertest branch from 0c24e6d to b67de20 Compare July 15, 2024 05:49

abevk2023 mentioned this pull request Jul 23, 2024

[Native] Add support for running functional tests on Mac M1/ARM64 #23275

Merged

tdcmeehan requested changes Jul 23, 2024

View reviewed changes

aditi-pandit reviewed Jul 23, 2024

View reviewed changes

Joe-Abraham force-pushed the containertest branch from 94ba486 to 90d7497 Compare July 24, 2024 08:39

Joe-Abraham marked this pull request as draft July 24, 2024 15:46

Joe-Abraham force-pushed the containertest branch 2 times, most recently from b928bc5 to 311da10 Compare July 25, 2024 06:21

Joe-Abraham requested review from tdcmeehan and aditi-pandit July 25, 2024 06:21

Joe-Abraham marked this pull request as ready for review July 25, 2024 06:24

Joe-Abraham force-pushed the containertest branch from 311da10 to 8011b8c Compare July 25, 2024 06:31

elharo reviewed Jul 25, 2024

View reviewed changes

Joe-Abraham force-pushed the containertest branch 4 times, most recently from 15bb23d to a90d325 Compare July 31, 2024 09:47

[native] Added functional testing framework using TestContainers

1522bb4

Joe-Abraham force-pushed the containertest branch from a90d325 to ecb833b Compare July 31, 2024 09:47

tdcmeehan reviewed Jul 31, 2024

View reviewed changes

Joe-Abraham force-pushed the containertest branch from ecb833b to 13f39a9 Compare July 31, 2024 13:58

Joe-Abraham requested a review from tdcmeehan July 31, 2024 14:01

tdcmeehan reviewed Jul 31, 2024

View reviewed changes

Joe-Abraham added 3 commits July 31, 2024 20:11

[native] Create ContainerQueryRunner and utility class

569d696

[native] Add initial basic native container test cases

538d6f4

[native] Add AbstractTestNativeTpchConnectorQueries

053c38d

Joe-Abraham force-pushed the containertest branch from 13f39a9 to 053c38d Compare July 31, 2024 14:41

tdcmeehan approved these changes Jul 31, 2024

View reviewed changes

tdcmeehan merged commit c2290c7 into prestodb:master Aug 1, 2024
59 checks passed

aditi-pandit reviewed Aug 1, 2024

View reviewed changes

Joe-Abraham deleted the containertest branch August 1, 2024 16:12

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Native] Introduce functional native test framework using TestContainers #23094

[Native] Introduce functional native test framework using TestContainers #23094

Joe-Abraham commented Jun 27, 2024 •

edited

Loading

steveburnett left a comment

tdcmeehan commented Jul 2, 2024

Joe-Abraham commented Jul 8, 2024

aditi-pandit left a comment

elharo Jul 25, 2024

elharo Jul 25, 2024

Joe-Abraham Jul 31, 2024

Joe-Abraham Jul 31, 2024

elharo Jul 25, 2024

tdcmeehan left a comment

tdcmeehan Jul 31, 2024

tdcmeehan Jul 31, 2024

tdcmeehan left a comment

tdcmeehan Jul 31, 2024

Joe-Abraham Jul 31, 2024

tdcmeehan Jul 31, 2024

Joe-Abraham Jul 31, 2024

aditi-pandit left a comment

	fail("Unsupported type: " + type);
	throw new UnsupportedOperationException("Unsupported type: " + type);

	Logger logger = Logger.getLogger(ContainerQueryRunner.class.getName());
	private static Logger logger = Logger.getLogger(ContainerQueryRunner.class.getName());

[Native] Introduce functional native test framework using TestContainers #23094

[Native] Introduce functional native test framework using TestContainers #23094

Conversation

Joe-Abraham commented Jun 27, 2024 • edited Loading

steveburnett left a comment

Choose a reason for hiding this comment

tdcmeehan commented Jul 2, 2024

Joe-Abraham commented Jul 8, 2024

aditi-pandit left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

tdcmeehan left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

tdcmeehan left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

aditi-pandit left a comment

Choose a reason for hiding this comment

Joe-Abraham commented Jun 27, 2024 •

edited

Loading