-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Treat Low Confidence, 0 estimations as unknown during joins #23047
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abhinavmuk04
force-pushed
the
milestone2p2
branch
2 times, most recently
from
June 27, 2024 21:52
2d27492
to
46c1268
Compare
abhinavmuk04
changed the title
Treat 0 Estimations as NaN
Treat 0 Estimations from TableScan as NaN
Jun 27, 2024
abhinavmuk04
force-pushed
the
milestone2p2
branch
2 times, most recently
from
June 28, 2024 21:56
306201d
to
a91174e
Compare
abhinavmuk04
changed the title
Treat 0 Estimations from TableScan as NaN
Treat Low Confidence, 0 estimations as unknown during joins
Jun 28, 2024
abhinavmuk04
force-pushed
the
milestone2p2
branch
7 times, most recently
from
July 1, 2024 23:08
e28cc10
to
b6f5816
Compare
abhinavmuk04
requested review from
jaystarshot,
feilong-liu and
a team
as code owners
July 1, 2024 23:10
abhinavmuk04
force-pushed
the
milestone2p2
branch
from
July 1, 2024 23:18
b6f5816
to
855fee0
Compare
.../main/java/com/facebook/presto/sql/planner/iterative/rule/DetermineJoinDistributionType.java
Outdated
Show resolved
Hide resolved
feilong-liu
reviewed
Jul 8, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also we need to have a session property to guard this feature.
.../main/java/com/facebook/presto/sql/planner/iterative/rule/DetermineJoinDistributionType.java
Outdated
Show resolved
Hide resolved
.../main/java/com/facebook/presto/sql/planner/iterative/rule/DetermineJoinDistributionType.java
Outdated
Show resolved
Hide resolved
abhinavmuk04
force-pushed
the
milestone2p2
branch
2 times, most recently
from
July 8, 2024 21:44
3655454
to
959e198
Compare
abhinavmuk04
force-pushed
the
milestone2p2
branch
2 times, most recently
from
July 11, 2024 20:17
1d9c8cd
to
49de2c9
Compare
I think a word ("joins") is missing from the release note entry. Suggested edit:
|
abhinavmuk04
force-pushed
the
milestone2p2
branch
2 times, most recently
from
July 11, 2024 21:02
d6f901a
to
5c35515
Compare
abhinavmuk04
force-pushed
the
milestone2p2
branch
3 times, most recently
from
July 12, 2024 18:24
d60f2d5
to
3aff711
Compare
feilong-liu
reviewed
Jul 13, 2024
...src/main/java/com/facebook/presto/sql/planner/iterative/LowConfidenceZeroEstimationUtil.java
Outdated
Show resolved
Hide resolved
.../main/java/com/facebook/presto/sql/planner/iterative/rule/DetermineJoinDistributionType.java
Outdated
Show resolved
Hide resolved
abhinavmuk04
force-pushed
the
milestone2p2
branch
from
July 13, 2024 06:45
3aff711
to
331adcf
Compare
feilong-liu
reviewed
Jul 15, 2024
...in/src/main/java/com/facebook/presto/sql/planner/iterative/ConfidenceBasedBroadcastUtil.java
Outdated
Show resolved
Hide resolved
...in/src/main/java/com/facebook/presto/sql/planner/iterative/ConfidenceBasedBroadcastUtil.java
Outdated
Show resolved
Hide resolved
.../main/java/com/facebook/presto/sql/planner/iterative/rule/DetermineJoinDistributionType.java
Outdated
Show resolved
Hide resolved
abhinavmuk04
force-pushed
the
milestone2p2
branch
from
July 15, 2024 22:46
331adcf
to
07c604d
Compare
abhinavmuk04
force-pushed
the
milestone2p2
branch
from
July 15, 2024 23:00
07c604d
to
bc59e0a
Compare
feilong-liu
approved these changes
Jul 16, 2024
34 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Treat Low Confidence, 0 estimations as unknown during joins
Motivation and Context
When a node has a low confidence and a 0 estimation it is likely due to the fact that there has been multiple filters pushed down on it. Additionally, sometimes this estimation can actually be so incorrect that it can have us broadcasting the wrong side entirely leading to a failed query. This will help us avoid this.
Impact
This can result in faster query execution times and improved overall performance.
Test Plan
Create plans tests where there are example of low confidence 0 estimation statistics and ensure behavior is as expected from the change. For more specific details on test plan please visit here
Contributor checklist
Release Notes