Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Verifier] Wrap checksum queries with partition predicate for reused output table #22965

Merged
merged 1 commit into from
Jul 19, 2024
Merged

[Verifier] Wrap checksum queries with partition predicate for reused output table #22965

merged 1 commit into from
Jul 19, 2024

Conversation

gggrace14
Copy link
Contributor

For Insert and CTAS queries, when output table reuse is on, build the partition
predicate and apply it when assembling the checksum queries.

== RELEASE NOTES ==

Verifier Changes
* Add `control.reuse-table` and `test.reuse-table` configuration properties for the Presto Verifier to reuse the output tables of the source query for control and test.

@gggrace14 gggrace14 requested review from steveburnett and a team as code owners June 10, 2024 03:21
@gggrace14 gggrace14 mentioned this pull request Jun 10, 2024
Merged
steveburnett
steveburnett requested changes Jun 10, 2024
View reviewed changes
Copy link
Contributor

@steveburnett steveburnett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the doc! Nit for formatting, looks good otherwise.

presto-docs/src/main/sphinx/admin/verifier.rst Outdated Show resolved Hide resolved
presto-docs/src/main/sphinx/admin/verifier.rst Outdated Show resolved Hide resolved
@gggrace14 gggrace14 force-pushed the scaledverifierpartition branch 4 times, most recently from b002bad to 2c8c7e3 Compare June 13, 2024 18:32
arhimondr
arhimondr previously approved these changes Jun 13, 2024
View reviewed changes
steveburnett
steveburnett previously approved these changes Jun 13, 2024
View reviewed changes
Copy link
Contributor

@steveburnett steveburnett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! (docs)

Pull updated branch, new doc build, looks good. Thanks!

@gggrace14
[Verifier] Wrap checksum queries with partition predicate for reused …
3c1b507 
…output table

For Insert and CTAS queries, when output table reuse is on, build the partition
predicate and apply it when assembling the checksum queries.
@gggrace14 gggrace14 dismissed stale reviews from steveburnett and arhimondr via 3c1b507 July 19, 2024 02:22
feilong-liu
feilong-liu approved these changes Jul 19, 2024
View reviewed changes
Copy link
Contributor

@feilong-liu feilong-liu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gggrace14 gggrace14 merged commit 632eb58 into prestodb:master Jul 19, 2024
56 checks passed
@gggrace14 gggrace14 deleted the scaledverifierpartition branch July 19, 2024 03:46
@tdcmeehan tdcmeehan mentioned this pull request Aug 23, 2024
Merged
34 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@feilong-liu feilong-liu feilong-liu approved these changes

@arhimondr arhimondr arhimondr left review comments

@steveburnett steveburnett steveburnett left review comments

@presto-oss presto-oss Awaiting requested review from presto-oss presto-oss is a code owner automatically assigned from prestodb/committers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gggrace14 @arhimondr @steveburnett @feilong-liu