-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable timestamp with time zone in create, alter and insert statements #22926
Disable timestamp with time zone in create, alter and insert statements #22926
Conversation
Nit - suggest edit to release note entry to include the PR number.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fix. Change looks good to me, only one little nits.
presto-iceberg/src/main/java/com/facebook/presto/iceberg/IcebergHiveMetadata.java
Show resolved
Hide resolved
presto-iceberg/src/main/java/com/facebook/presto/iceberg/IcebergUtil.java
Outdated
Show resolved
Hide resolved
b513c81
to
9307809
Compare
Timestamp with time zone is not allowed in DDL statements because inserts fail, but tables with timestamp with time zone can be registered and queried.
dbc37bb
to
d29dc9b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for the fix. Please rerun the fail test.
@wanglinsong can we backport this into 0.285, 0.286 and 0.287? |
Timestamp with time zone is not allowed in DDL statements because inserts fail, but tables with timestamp with time zone can be registered and queried.
Description
Presto issue #22794
Motivation and Context
When querying an Iceberg table in AWS Glue the following error is received: 'Iceberg column type timestamptz is not supported'. This worked before Presto 0.285. It is related to #21096
Impact
Create table, alter table and insert statements having "timestamp with time zone" will return error for Iceberg tables:
'Iceberg column type timestamptz is not supported'.
But existent Iceberg tables with timestamp with time zone can be registered and queried.
Test Plan
Add a new test in IcebergDistributedSmokeTestBase
Contributor checklist
Release Notes
Please follow release notes guidelines and fill in the release notes below.