Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable timestamp with time zone in create, alter and insert statements #22926

Merged

Conversation

denodo-research-labs
Copy link
Contributor

@denodo-research-labs denodo-research-labs commented Jun 5, 2024

Timestamp with time zone is not allowed in DDL statements because inserts fail, but tables with timestamp with time zone can be registered and queried.

Description

Presto issue #22794

Motivation and Context

When querying an Iceberg table in AWS Glue the following error is received: 'Iceberg column type timestamptz is not supported'. This worked before Presto 0.285. It is related to #21096

Impact

Create table, alter table and insert statements having "timestamp with time zone" will return error for Iceberg tables:
'Iceberg column type timestamptz is not supported'.
But existent Iceberg tables with timestamp with time zone can be registered and queried.

Test Plan

Add a new test in IcebergDistributedSmokeTestBase

Contributor checklist

  • Please make sure your submission complies with our development, formatting, commit message, and attribution guidelines.
  • PR description addresses the issue accurately and concisely. If the change is non-trivial, a GitHub Issue is referenced.
  • Documented new properties (with its default value), SQL syntax, functions, or other functionality.
  • If release notes are required, they follow the release notes guidelines.
  • Adequate tests were added if applicable.
  • CI passed.

Release Notes

Please follow release notes guidelines and fill in the release notes below.

== RELEASE NOTES ==

Iceberg Connector Changes
* Disable timestamp with time zone in create, alter and insert statements :pr:`22926`

@steveburnett
Copy link
Contributor

Nit - suggest edit to release note entry to include the PR number.

== RELEASE NOTES ==

Iceberg Connector Changes
* Disable timestamp with time zone in create, alter and insert statements :pr:`22926`

Copy link
Member

@hantangwangd hantangwangd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix. Change looks good to me, only one little nits.

gupteaj
gupteaj previously approved these changes Jun 5, 2024
Timestamp with time zone is not allowed in DDL statements
because inserts fail, but tables with timestamp with time zone
can be registered and queried.
Copy link
Member

@hantangwangd hantangwangd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the fix. Please rerun the fail test.

@tdcmeehan tdcmeehan merged commit eca969c into prestodb:master Jun 7, 2024
56 checks passed
@denodo-research-labs denodo-research-labs deleted the iceberg_disable_timestamptz branch June 7, 2024 07:20
@tdcmeehan
Copy link
Contributor

@wanglinsong can we backport this into 0.285, 0.286 and 0.287?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants