[native] Transfer idle HTTPSession between IO threads in exchange source #22922
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xiaoxmeng
approved these changes
Jun 4, 2024
… source (prestodb#22903) Summary: Currently each endpoint (server) has only one `SessionPool`, which can only be attached to one `EventBase`. If there is some skewness among the distribution (i.e. too many endpoints being attached to one event base), that event base would become bottleneck and cause regression in query wall time. Fix this by creating one `SessionPool` for each endpoint and event base pair. Allow transfer of idle session between different event bases by using `ServerIdleSessionController`. This way we eliminate the bottleneck in event base while still keep the `HttpSession`s reusable. After the fix, enabling connection pool should no longer cause any regression to wall time. The SSL handshake cost (`EVP_DigestSignFinal`) is not visible in shuffle heavy queries when connection pool is enabled. Reviewed By: xiaoxmeng, arhimondr Differential Revision: D57842433
36 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently each endpoint (server) has only one
SessionPool, which can only be attached to oneEventBase. If there is some skewness among the distribution (i.e. too many endpoints being attached to one event base), that event base would become bottleneck and cause regression in query wall time.Fix this by creating one
SessionPoolfor each endpoint and event base pair. Allow transfer of idle session between different event bases by usingServerIdleSessionController. This way we eliminate the bottleneck in event base while still keep theHttpSessions reusable.After the fix, enabling connection pool should no longer cause any regression to wall time. The SSL handshake cost (
EVP_DigestSignFinal) is not visible in shuffle heavy queries when connection pool is enabled.Reviewed By: xiaoxmeng, arhimondr
Differential Revision: D57842433