Add coordinator sidecar process #22854
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pdabre12
changed the title
pdabre12
force-pushed
the
add-coordinator-sidecar
branch
2 times, most recently
from
28db967
to
6558ca5
Compare
tdcmeehan
requested changes
Jun 4, 2024
presto-main/src/main/java/com/facebook/presto/execution/ClusterSizeMonitor.java
Show resolved
Hide resolved
pdabre12
force-pushed
the
add-coordinator-sidecar
branch
2 times, most recently
from
8f4847f
to
44fa41e
Compare
tdcmeehan
requested changes
Jun 5, 2024
presto-main/src/main/java/com/facebook/presto/execution/ClusterSizeMonitor.java
Outdated
Show resolved
Hide resolved
presto-main/src/main/java/com/facebook/presto/execution/ClusterSizeMonitor.java
Outdated
Show resolved
Hide resolved
presto-main/src/main/java/com/facebook/presto/server/ServerConfig.java
Outdated
Show resolved
Hide resolved
pdabre12
force-pushed
the
add-coordinator-sidecar
branch
from
74e302c
to
0bec8fa
Compare
|
|
pdabre12
force-pushed
the
add-coordinator-sidecar
branch
2 times, most recently
from
08e1844
to
874e168
Compare
tdcmeehan
reviewed
Jun 5, 2024
presto-main/src/main/java/com/facebook/presto/dispatcher/LocalDispatchQuery.java
Outdated
Show resolved
Hide resolved
pdabre12
force-pushed
the
add-coordinator-sidecar
branch
from
874e168
to
ec91078
Compare
tdcmeehan
reviewed
Jun 6, 2024
presto-main/src/main/java/com/facebook/presto/server/ServerMainModule.java
Outdated
Show resolved
Hide resolved
pdabre12
force-pushed
the
add-coordinator-sidecar
branch
2 times, most recently
from
fecb38f
to
79b5b95
Compare
pdabre12
requested review from
shrinidhijoshi,
a team,
jaystarshot and
feilong-liu
as code owners
|
@aditi-pandit PTAL. |
@pdabre12 : Looks good. Thanks. |
tdcmeehan
requested changes
Jun 7, 2024
presto-spi/src/main/java/com/facebook/presto/spi/StandardErrorCode.java
Outdated
Show resolved
Hide resolved
presto-main/src/main/java/com/facebook/presto/dispatcher/LocalDispatchQuery.java
Outdated
Show resolved
Hide resolved
presto-main/src/main/java/com/facebook/presto/execution/ClusterSizeMonitor.java
Outdated
Show resolved
Hide resolved
tdcmeehan
reviewed
Jun 13, 2024
pdabre12
force-pushed
the
add-coordinator-sidecar
branch
from
3806dfc
to
76f6da9
Compare
|
@tdcmeehan Squashed the commits, thank you. |
tdcmeehan
reviewed
Jun 25, 2024
presto-main/src/main/java/com/facebook/presto/dispatcher/LocalDispatchQuery.java
Outdated
Show resolved
Hide resolved
pdabre12
force-pushed
the
add-coordinator-sidecar
branch
from
76f6da9
to
c40a3f7
Compare
tdcmeehan
approved these changes
Jun 25, 2024
34 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for a new Presto process type, the sidecar.
Resolves: #22829