-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add coordinator sidecar process #22854
Conversation
28db967
to
6558ca5
Compare
presto-main/src/main/java/com/facebook/presto/execution/ClusterSizeMonitor.java
Show resolved
Hide resolved
8f4847f
to
44fa41e
Compare
presto-main/src/main/java/com/facebook/presto/execution/ClusterSizeMonitor.java
Outdated
Show resolved
Hide resolved
presto-main/src/main/java/com/facebook/presto/execution/ClusterSizeMonitor.java
Outdated
Show resolved
Hide resolved
presto-main/src/main/java/com/facebook/presto/server/ServerConfig.java
Outdated
Show resolved
Hide resolved
74e302c
to
0bec8fa
Compare
|
08e1844
to
874e168
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One more nit
presto-main/src/main/java/com/facebook/presto/dispatcher/LocalDispatchQuery.java
Outdated
Show resolved
Hide resolved
874e168
to
ec91078
Compare
presto-main/src/main/java/com/facebook/presto/server/ServerMainModule.java
Outdated
Show resolved
Hide resolved
fecb38f
to
79b5b95
Compare
@aditi-pandit PTAL. |
@pdabre12 : Looks good. Thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple of minor cleanups
presto-spi/src/main/java/com/facebook/presto/spi/StandardErrorCode.java
Outdated
Show resolved
Hide resolved
presto-main/src/main/java/com/facebook/presto/dispatcher/LocalDispatchQuery.java
Outdated
Show resolved
Hide resolved
presto-main/src/main/java/com/facebook/presto/execution/ClusterSizeMonitor.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, please squash commits
3806dfc
to
76f6da9
Compare
@tdcmeehan Squashed the commits, thank you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one more nit, will merge after that.
presto-main/src/main/java/com/facebook/presto/dispatcher/LocalDispatchQuery.java
Outdated
Show resolved
Hide resolved
76f6da9
to
c40a3f7
Compare
Adds support for a new Presto process type, the sidecar.
Resolves: #22829