-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Connector changes for time travel BEFORE clause. #22851
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! (docs)
Pull branch, local docs build, everything looks good. Thanks!
Suggest revising the release note entry following the Order of changes and Section naming topics in the Release Notes Guidelines.
If the examples are valuable, suggest adding them to the Iceberg Connector documentation. |
I overlooked "add PR # to the release note entry" in my previous comment, apologies for that!
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the work, change looks good to me. Only one little thing in test.
presto-iceberg/src/test/java/com/facebook/presto/iceberg/TestIcebergTableVersion.java
Outdated
Show resolved
Hide resolved
cd3baae
to
b3e95f8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! (docs)
Pull updated branch, review new local docs build, everything looks good. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
b3e95f8
to
734fc60
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @gupteaj
Presto issue : #21971
Note - This PR has iceberg connector changes, test and doc update. Syntax change for "BEFORE" keyword in presto engine is already merged.
This feature will allow iceberg connector to query historical data using BEFORE syntax on a table.
Time travel version option will read bigint snapshot id value for the table. Time travel timestamp option will read
timestamp-with-time-zone value for the table.
Examples
Iceberg connector
Motivation and Context
Snowflake provides a BEFORE clause for time travel queries. When used in a query, this clause is specified in the FROM clause immediately after the table name. It determines the point in the past from which historical data is requested for the object. The AT keyword includes changes made by a statement or transaction with a timestamp equal to the specified parameter, while the BEFORE keyword refers to a point immediately preceding the specified parameter.
IBM Netezza supports BEFORE clause similar to Snowflake.
Impact
A new table level option to return specific snapshot for iceberg connector
Test Plan
Contributor checklist
Release Notes
Please follow release notes guidelines and fill in the release notes below.