-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Iceberg]Support year/month/day/hour transforms both on legacy and non-legacy TimestampType column #21959
[Iceberg]Support year/month/day/hour transforms both on legacy and non-legacy TimestampType column #21959
Conversation
ec9a17b
to
d2564de
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the main logic looks ok. Just a few nits and one question
presto-main/src/main/java/com/facebook/presto/type/TimestampOperators.java
Show resolved
Hide resolved
presto-iceberg/src/main/java/com/facebook/presto/iceberg/IcebergPageSink.java
Outdated
Show resolved
Hide resolved
presto-iceberg/src/main/java/com/facebook/presto/iceberg/IcebergPageSink.java
Outdated
Show resolved
Hide resolved
presto-iceberg/src/main/java/com/facebook/presto/iceberg/IcebergPageSink.java
Outdated
Show resolved
Hide resolved
d2564de
to
26ad1d2
Compare
26ad1d2
to
1176993
Compare
Can you add to the release note an explanation of the bug fix on Timestamp to Date conversion? |
Sure, it has been added! Please take a look, thanks! |
Changes looks good to me. In general, I see many references to the legacy system property, can we create a common function for these cases ? |
1176993
to
766010a
Compare
@gupteaj sure, good suggestion! Fixed! |
766010a
to
9379d49
Compare
Description
When we create partitions on TimestampType columns(using year/month/day/hour transform) in Iceberg, we will meet various problems because of the legacy timestamp logic in presto engine do not match the logic used in Iceberg transform calculation. See issue: #7122 .
This PR fix the problems, and correct the behaviors for both legacy and non-legacy timestamp.
Test Plan
Contributor checklist
Release Notes