Fix spooling output buffer unit test #15905
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tdcmeehan
reviewed
Apr 6, 2021
presto-main/src/test/java/com/facebook/presto/execution/buffer/TestSpoolingOutputBuffer.java
Show resolved
Hide resolved
tdcmeehan
approved these changes
Apr 6, 2021
|
Please add some context in the description. |
swapsmagic
approved these changes
Apr 6, 2021
basarhamdionat
approved these changes
Apr 6, 2021
tsaichien
force-pushed
the
spooling-test-fix
branch
from
c8cf125
to
8b9b14e
Compare
tdcmeehan
approved these changes
Apr 8, 2021
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The unit tests for
SpoolingOutputBufferwere disabled due to flakey tests. The executor in theSpoolingOutputBufferFactorywas static and would get shutdown when the GC from other tests cleans up the factory, causing the tasks inTestSpoolingOutputBufferto get rejected.