Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding F dist (#15798) #15811

Closed
wants to merge 3 commits into from
Closed

adding F dist (#15798) #15811

wants to merge 3 commits into from

Conversation

Masha-Iris
Copy link
Contributor

Test plan - (Please fill in how you tested your changes)

Please make sure your submission complies with our Development, Formatting, and Commit Message guidelines. Don't forget to follow our attribution guidelines for any code copied from other projects.

Fill in the release notes towards the bottom of the PR description.
See Release Notes Guidelines for details.

== RELEASE NOTES ==

General Changes
* ...
* ...

Hive Changes
* ...
* ...

If release note is NOT required, use:

== NO RELEASE NOTE ==

@leepface
Copy link
Contributor

Looks like you have some unrelated "temp storage" changes in here. I think you need to rebase.

@leepface
Copy link
Contributor

Code review:

  • maven-checks errors are code formatting. Load in IntelliJ (no need for working build environment) and code format.

@talgalili
Copy link
Contributor

@Masha-Iris - please clean up this diff also :)

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Apr 18, 2021

CLA Signed

The committers are authorized under a signed CLA.

@talgalili
Copy link
Contributor

@Masha-Iris - could you please fix the "This branch has conflicts that must be resolved" issue?
(you'll need to re-base)

@talgalili
Copy link
Contributor

Your diff seems to include irrelevant files changes. You'll need to remove them from the diff (or, in worst case scenario, start a new diff with only the changes you want)

@talgalili
Copy link
Contributor

Hey @Masha-Iris - I see that this diff has merge conflicts, could you please resolve them?

@talgalili
Copy link
Contributor

@Masha-Iris - I think this diff wasn't merged properly. I see you have 3 commits in it, and also that it includes adding other diffs as new content within your own diff. Please review.

@ajaygeorge
Copy link
Contributor

@Masha-Iris Can you please take a look at resolving the merge conflicts.
cc @jbapple

@stale
Copy link

stale bot commented Apr 16, 2022

This pull request has been automatically marked as stale because it has not had recent activity. If you'd still like this PR merged, please comment on the task, make sure you've addressed reviewer comments, and rebase on the latest master. Thank you for your contributions!

@stale stale bot added the stale label Apr 16, 2022
@stale stale bot closed this Apr 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants