Fix creating empty non-bucketed Hive partition #12204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, creating empty non-bucketed Hive partition procedure call does not work when the WriteMode is STAGE_AND_MOVE_TO_TARGET_DIRECTORY, since no file is created and the stage directory will not exist.
wenleix
force-pushed
the
fix-empty-partition
branch
from
0d63a57
to
8534b1d
Compare
|
Blocked #11376 |
Merged
shixuan-fan
reviewed
Jan 30, 2019
| @Test | ||
| public void testCreateEmptyNonBucketedPartition() | ||
| { | ||
| String tableName = "test_insert_empty_partitioned_unbucketed_table"; |
There was a problem hiding this comment.
Does this test the scenario of STAGE_AND_MOVE_TO_TARGET_DIRECTORY? This might sound noob but I didn't see where the write mode is set.
There was a problem hiding this comment.
I think it doesn't matter. For empty partition, we just need to create an empty directory and we can directly create it as the target path.
There was a problem hiding this comment.
@shixuan-fan : STAGE_AND_MOVE_TO_TARGET_DIRECTORY is used in open source Hive Connector, unless underlying file system is S3 in which rename is expensive . See
and
The session property hive.temporary-staging-directory-enabled was added recently by #12199 for S3 filesystem in disguise.
electrum
pushed a commit
to electrum/trino
that referenced
this pull request
Jan 30, 2019
Previously, creating empty non-bucketed Hive partition procedure call does not work when the WriteMode is STAGE_AND_MOVE_TO_TARGET_DIRECTORY, since no file is created and the stage directory will not exist. Extracted-From: prestodb/presto#12204
electrum
pushed a commit
to trinodb/trino
that referenced
this pull request
Jan 31, 2019
Previously, creating empty non-bucketed Hive partition procedure call does not work when the WriteMode is STAGE_AND_MOVE_TO_TARGET_DIRECTORY, since no file is created and the stage directory will not exist. Extracted-From: prestodb/presto#12204
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, creating empty non-bucketed Hive partition procedure call
does not work when the WriteMode is STAGE_AND_MOVE_TO_TARGET_DIRECTORY,
since no file is created and the stage directory will not exist.
Fixes #12002