DATE/TIME/TIMESTAMP/ZONE improvements in base-jdbc and tests #10114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
losipiuk
approved these changes
Mar 7, 2018
This moves `AbstractTestQueries#evaluateScalar` method to `AbstractTestQueryFramework` and renames it to `computeScalar` to better match other existing methods.
This test must be run against both `LocalQueryRunner` and `DistributedQueryRunner`, since these runners differ in a way how they return data. For this reason it was placed in `AbstractTestQueries`. However, this test is not connector-specific, so dedicated class is more appropriate.
JDBC's `ResultSet.getTimestamp(int)` cannot correctly return a `TIMESTAMP` value that did not occur in local time zone (due to DST or policy changes). Similarly, `ResultSet.getTime(int)` cannot correctly return `TIME` value, if that local time did not occur in local time zone on 1970-01-01.
…DATE For this, `H2QueryRunner` needs to be able to convert a DATE value to TIMESTAMP. It used to be able when `ResultSet.getTimestamp` was used to retrieve the TIMESTAMP value, but this broke when Java Time classes were used to retrieve values from the `ResultSet`.
losipiuk
approved these changes
Mar 8, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.