Add entry to parquet metadata cache on file modificationTime

prestodb · May 23, 2024 · faa3a55 · faa3a55
1 parent cf0ac07
commit faa3a55
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 6 deletions.
diff --git a/presto-hive/src/test/java/com/facebook/presto/hive/parquet/AbstractTestParquetReader.java b/presto-hive/src/test/java/com/facebook/presto/hive/parquet/AbstractTestParquetReader.java
@@ -1701,8 +1701,8 @@ public void testCaching()
                     parquetMetadataSource,
                     tempFile.getFile(),
                     tempFileModificationTime);
-            assertEquals(parquetFileMetadataCache.stats().missCount(), 3);
-            assertEquals(parquetFileMetadataCache.stats().hitCount(), 4);
+            assertEquals(parquetFileMetadataCache.stats().missCount(), 2);
+            assertEquals(parquetFileMetadataCache.stats().hitCount(), 5);
         }
     }
 

diff --git a/...parquet/src/main/java/com/facebook/presto/parquet/cache/CachingParquetMetadataSource.java b/...parquet/src/main/java/com/facebook/presto/parquet/cache/CachingParquetMetadataSource.java
@@ -54,12 +54,12 @@ public ParquetFileMetadata getParquetMetadata(
                 ParquetFileMetadata fileMetadataCache = cache.get(
                         parquetDataSource.getId(),
                         () -> delegate.getParquetMetadata(parquetDataSource, fileSize, cacheable, modificationTime, fileDecryptor, readMaskedValue));
-                if (fileMetadataCache.getModificationTime() == modificationTime) {
-                    return fileMetadataCache;
-                }
-                else {
+                if (fileMetadataCache.getModificationTime() != modificationTime) {
                     cache.invalidate(parquetDataSource.getId());
+                    fileMetadataCache = delegate.getParquetMetadata(parquetDataSource, fileSize, cacheable, modificationTime, fileDecryptor, readMaskedValue);
+                    cache.put(parquetDataSource.getId(), fileMetadataCache);
                 }
+                return fileMetadataCache;
             }
             return delegate.getParquetMetadata(parquetDataSource, fileSize, cacheable, modificationTime, fileDecryptor, readMaskedValue);
         }