[native] Remove mmap arena exposure from Prestissimo

prestodb · Jan 17, 2024 · 87c1fec · 87c1fec
1 parent 0c76a0d
commit 87c1fec
Show file tree

Hide file tree

Showing 3 changed files with 0 additions and 20 deletions.
diff --git a/presto-native-execution/presto_cpp/main/PrestoServer.cpp b/presto-native-execution/presto_cpp/main/PrestoServer.cpp
@@ -616,8 +616,6 @@ void PrestoServer::initializeVeloxMemory() {
   options.allocatorCapacity = memoryGb << 30;
   if (systemConfig->useMmapAllocator()) {
     options.useMmapAllocator = true;
-    options.useMmapArena = systemConfig->useMmapArena();
-    options.mmapArenaCapacityRatio = systemConfig->mmapArenaCapacityRatio();
   }
   options.checkUsageLeak = systemConfig->enableMemoryLeakCheck();
   options.trackDefaultUsage =

diff --git a/presto-native-execution/presto_cpp/main/common/Configs.cpp b/presto-native-execution/presto_cpp/main/common/Configs.cpp
@@ -175,8 +175,6 @@ SystemConfig::SystemConfig() {
           STR_PROP(kAsyncCacheSsdPath, "/mnt/flash/async_cache."),
           STR_PROP(kAsyncCacheSsdDisableFileCow, "false"),
           STR_PROP(kEnableSerializedPageChecksum, "true"),
-          STR_PROP(kUseMmapArena, "false"),
-          NUM_PROP(kMmapArenaCapacityRatio, 10),
           STR_PROP(kUseMmapAllocator, "true"),
           STR_PROP(kMemoryArbitratorKind, ""),
           NUM_PROP(kQueryMemoryGb, 38),
@@ -431,14 +429,6 @@ bool SystemConfig::enableVeloxExprSetLogging() const {
   return optionalProperty<bool>(kEnableVeloxExprSetLogging).value();
 }
 
-bool SystemConfig::useMmapArena() const {
-  return optionalProperty<bool>(kUseMmapArena).value();
-}
-
-int32_t SystemConfig::mmapArenaCapacityRatio() const {
-  return optionalProperty<int32_t>(kMmapArenaCapacityRatio).value();
-}
-
 bool SystemConfig::useMmapAllocator() const {
   return optionalProperty<bool>(kUseMmapAllocator).value();
 }

diff --git a/presto-native-execution/presto_cpp/main/common/Configs.h b/presto-native-execution/presto_cpp/main/common/Configs.h
@@ -298,10 +298,6 @@ class SystemConfig : public ConfigBase {
   /// cache entries.
   static constexpr std::string_view kCacheVeloxTtlCheckInterval{
       "cache.velox.ttl-check-interval"};
-
-  static constexpr std::string_view kUseMmapArena{"use-mmap-arena"};
-  static constexpr std::string_view kMmapArenaCapacityRatio{
-      "mmap-arena-capacity-ratio"};
   static constexpr std::string_view kUseMmapAllocator{"use-mmap-allocator"};
 
   /// Specifies the memory arbitrator kind. If it is empty, then there is no
@@ -588,10 +584,6 @@ class SystemConfig : public ConfigBase {
 
   bool enableVeloxExprSetLogging() const;
 
-  bool useMmapArena() const;
-
-  int32_t mmapArenaCapacityRatio() const;
-
   bool useMmapAllocator() const;
 
   std::string memoryArbitratorKind() const;