Pass cat token for view definer mode

Currently for view definer mode in Presto, extra credentials such as CAT tokens are not passed. This change ensures that all extra credentials are passed in the view definer mode.
prestodb · Jan 12, 2024 · 6b9f680 · 6b9f680
1 parent e01dc52
commit 6b9f680
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 2 deletions.
diff --git a/presto-main/src/main/java/com/facebook/presto/sql/MaterializedViewUtils.java b/presto-main/src/main/java/com/facebook/presto/sql/MaterializedViewUtils.java
@@ -109,7 +109,7 @@ public static Session buildOwnerSession(Session session, Optional<String> owner,
     public static Identity getOwnerIdentity(Optional<String> owner, Session session)
     {
         if (owner.isPresent() && !owner.get().equals(session.getIdentity().getUser())) {
-            return new Identity(owner.get(), Optional.empty());
+            return new Identity(owner.get(), Optional.empty(), session.getIdentity().getExtraCredentials());
         }
         return session.getIdentity();
     }

diff --git a/presto-main/src/main/java/com/facebook/presto/sql/analyzer/StatementAnalyzer.java b/presto-main/src/main/java/com/facebook/presto/sql/analyzer/StatementAnalyzer.java
@@ -2803,7 +2803,7 @@ private RelationType analyzeView(Query query, QualifiedObjectName name, Optional
                 Identity identity;
                 AccessControl viewAccessControl;
                 if (owner.isPresent() && !owner.get().equals(session.getIdentity().getUser())) {
-                    identity = new Identity(owner.get(), Optional.empty());
+                    identity = new Identity(owner.get(), Optional.empty(), session.getIdentity().getExtraCredentials());
                     viewAccessControl = new ViewAccessControl(accessControl);
                 }
                 else {

diff --git a/presto-spi/src/main/java/com/facebook/presto/spi/security/Identity.java b/presto-spi/src/main/java/com/facebook/presto/spi/security/Identity.java
@@ -56,6 +56,11 @@ public Identity(String user, Optional<Principal> principal)
         this(user, principal, emptyMap(), emptyMap(), emptyMap(), Optional.empty(), Optional.empty());
     }
 
+    public Identity(String user, Optional<Principal> principal, Map<String, String> extraCredentials)
+    {
+        this(user, principal, emptyMap(), extraCredentials, emptyMap(), Optional.empty(), Optional.empty());
+    }
+
     public Identity(
             String user,
             Optional<Principal> principal,