Upgrade Jetty from 9.4.14.v20181114 to 9.4.54.v20240208 to Address Security Vulnerabilities #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…v20231009 have a new vulnerability
siddhuoo7
changed the title
tdcmeehan
requested changes
Jul 2, 2024
Comment on lines
+365
to
+371
| return null; | ||
| } | ||
|
|
||
| @Override | ||
| public Object getTag() | ||
| { | ||
| return null; |
There was a problem hiding this comment.
Suggested change
| return null; | |
| } | |
| @Override | |
| public Object getTag() | |
| { | |
| return null; | |
| throw new UnsupportedOperationException(); | |
| } | |
| @Override | |
| public Object getTag() | |
| { | |
| throw new UnsupportedOperationException(); |
| @@ -638,7 +639,7 @@ public void testResponseStatusMessage() | |||
| assertNull(statusMessage); | |||
| } | |||
| else { | |||
| assertEquals(statusMessage, "message"); | |||
| assertEquals(statusMessage, "OK"); | |||
There was a problem hiding this comment.
This seems unexpected given the test setup in line 629:
| @@ -747,7 +748,7 @@ public void testCompressionIsDisabled() | |||
| assertEquals(body, ""); | |||
| assertFalse(servlet.getRequestHeaders().containsKey(HeaderName.of(ACCEPT_ENCODING))); | |||
|
|
|||
| String json = "{\"foo\":\"bar\",\"hello\":\"world\"}"; | |||
| String json = "{\"fuite\":\"apple\",\"hello\":\"world\"}"; | |||
|
@siddhuoo7 are you still working on this PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull request upgrades the Jetty server dependency from version 9.4.14.v20181114 to 9.4.54.v20240208. This update addresses several known security vulnerabilities and includes numerous improvements and bug fixes.
Details
Vulnerabilities Addressed
Upgrading to Jetty 9.4.53.v20231009 addresses multiple security vulnerabilities, including but not limited to:
Improvements and Bug Fixes
In addition to security fixes, this upgrade includes several performance improvements and bug fixes. Notable changes are:
Testing
Thorough testing has been conducted to ensure compatibility and stability with our existing application. Tests include: