feat: Add Unwrap to PartialError #815
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mfridman
reviewed
Aug 26, 2024
provider_errors_test.go
Outdated
| "github.com/pressly/goose/v3/internal/check" | ||
| ) | ||
|
|
||
| func TestPartialErrorUnwrap(t *testing.T) { |
There was a problem hiding this comment.
Mind moving this to provider_test.go, so we can avoid creating a new file?
Otherwise, great idea!
There was a problem hiding this comment.
Done. Thanks for Goose!
This allows PartialError to expose the error it wraps so that is compatible with Go's error inspection machinery defined in package errors.
mfridman
approved these changes
Aug 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows
PartialErrorto expose the error it wraps so that it is compatible with Go's error inspection machinery defined in package errors.