-
Notifications
You must be signed in to change notification settings - Fork 523
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Missing migrations handling. BMP-596 #72
Missing migrations handling. BMP-596 #72
Conversation
…ing, up-with-missing. BMP-596
|
||
# Install | ||
|
||
$ go get -u github.com/pressly/goose/cmd/goose | ||
$ go get -u github.com/mc2soft/goose/cmd/goose |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You don't expect us to merge this change github.com/mc2soft/goose
, do you? :)
Can you iron this PR out and provide a high-level overview of what is this PR supposed to solve? Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR resolves #73. Ok, i will iron it to avoid "mc2soft" mentions)) But pls give me feedback, do you consider such issue?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So in the high-level, this would find all the missing migrations -- ie. all migrations that are available but were not applied in the DB, right?
You can
- list them
- apply them
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, with new commands:
- status-missing
- up-missing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now, do we need 1. at all? Can't goose status
show these migrations as well by default?
Imho, 2. is explicit enough. I like it. It might even help people who insist on using Timestamp based migrations #63.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
status
show all migrations (could be a lot of them!), including missing ("pending"). But the new status-missing
shows only missing migrations.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd like someone from #63 to test this feature. I don't really have the same use case. Can you ping these guys, once you have the PR ready?
…ate current DB. Accepted by up and up-by-one commands.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is still not finished. We can't merge references to the github.com/mc2soft/goose fork.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Stepych are you planning to finish this PR?
Or should we freeze it / close it? Thanks!
Closing due to inactivity EDIT:
|
resolves #73