Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support recursive collection of source files for provider using fs.FS #706

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

fmarmol
Copy link

@fmarmol fmarmol commented Feb 27, 2024

Hello,

Since its easy to add any subfolders in embed.FS, wanted to support collection of source files recursively for the new provider API using fs.FS. What do you think about this PR ?

@fmarmol fmarmol force-pushed the support_recursive_search_in_filesystem_for_new_provider_api branch from cd26a9e to 11ba682 Compare February 27, 2024 11:30
@fmarmol fmarmol force-pushed the support_recursive_search_in_filesystem_for_new_provider_api branch from 11ba682 to 9407563 Compare February 27, 2024 11:34
@mfridman
Copy link
Collaborator

Interesting, I'm curious to understand what problem this would solve?

Is this related to #349 by any chance?

@fmarmol
Copy link
Author

fmarmol commented May 3, 2024

Hi @mfridman

Its not directly linked, but the problem is similar. In my case it was common migrations files compatible for postgresql and sqlite and specific folder for each database

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants