Fix rafting issues. #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit ensures that each pod has its own cluster IP service. This makes sure that "pod ips" do not change. Fixes presslabs/docker-orchestrator/#4. Orchestrator can automatically route traffic to the leader. By making a service that talks to all pods + using the right http advertise config value. Fixes presslabs/docker-orchestrator/#4 Fixes bitpoke/mysql-operator#107
AMecea
reviewed
Jun 24, 2019
There was a problem hiding this comment.
Thank you for this contribution! Nice work!
We recently (starting with version 0.3.0.rc.3 of the mysql-operator), dropped this orchestrator chart and merge it into the mysql-operator chart. We did this because they are tightly coupled.
I will merge this PR after I will test it, maybe someone uses this chart. But please open the same PR against mysql-operator chart.
|
Alright, ill open a MR in that repo as well 👍 |
calind
pushed a commit
to bitpoke/mysql-operator
that referenced
this pull request
Jul 1, 2019
Fixes #107 This commit makes a service for each pod by using the unique statefull set name label. These services ensure that there is a cluster ip reserved for each pod. The rafting uses these cluster ips. Orchestrator will proxy/route traffic to its leader. So, the main service can be used as entry point and all the trafic will be routed to the leader. See: https://github.com/github/orchestrator/blob/master/docs/configuration-raft.md See: presslabs/docker-orchestrator#8 Signed-off-by: Kevin Hellemun <[email protected]>
|
@AMecea shall we close this one because it got merged in the other repo or? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit ensures that each pod has its own cluster IP service. This
makes sure that "pod ips" do not change. Fixes
presslabs/docker-orchestrator/#4.
Orchestrator can automatically route traffic to the leader. By making a
service that talks to all pods + using the right http advertise config
value.
Fixes #4
Fixes bitpoke/mysql-operator#107