-
Notifications
You must be signed in to change notification settings - Fork 729
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Brakeman crashes while printing warning for Ruby EOL 2.6 #1671
Comments
Ah, embarrassing. I'll get a fix out ASAP. |
presidentbeef
added a commit
that referenced
this issue
Jan 30, 2022
presidentbeef
added a commit
that referenced
this issue
Jan 30, 2022
Fixed with 5.2.1. Thanks and apologies! |
@presidentbeef no problem. Thanks for the quick fix! |
Repository owner
locked and limited conversation to collaborators
Jun 3, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Earlier this morning we started seeing Brakeman crash with error:
I traced the error and found that it crashed while reporting a warning for
CheckEOLRuby
. The root cause appears to be that the warning symbol:pending_eol_ruby
was introduced recently here in #1660, but never had a numeric code registered.I was able to fix the problem by editing https://github.com/presidentbeef/brakeman/blob/main/lib/brakeman/warning_codes.rb to assign
:pending_eol_ruby
a numeric code.The text was updated successfully, but these errors were encountered: