Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Fix Pylint errors #225

Merged
merged 2 commits into from
Jul 5, 2022
Merged

chore: Fix Pylint errors #225

merged 2 commits into from
Jul 5, 2022

Conversation

AAfghahi
Copy link

SUMMARY

This will be going through and fixing many of the pylint errors that are in chart-power-query

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@AAfghahi AAfghahi force-pushed the arash/pylint_errors branch 15 times, most recently from ea54850 to 2e87fa2 Compare July 1, 2022 21:30
@AAfghahi AAfghahi force-pushed the arash/pylint_errors branch 2 times, most recently from ce62114 to be70356 Compare July 5, 2022 16:35
@codecov-commenter
Copy link

Codecov Report

Merging #225 (ac8c17f) into chart-power-query (e076f13) will decrease coverage by 12.21%.
The diff coverage is 64.39%.

❗ Current head ac8c17f differs from pull request most recent head be70356. Consider uploading reports for the commit be70356 to get more accurate results

@@                  Coverage Diff                   @@
##           chart-power-query     #225       +/-   ##
======================================================
- Coverage              66.67%   54.46%   -12.22%     
======================================================
  Files                   1738     1751       +13     
  Lines                  65081    66148     +1067     
  Branches                6888     6912       +24     
======================================================
- Hits                   43393    36025     -7368     
- Misses                 19939    28374     +8435     
  Partials                1749     1749               
Flag Coverage Δ
hive ?
mysql ?
postgres ?
presto 52.90% <65.30%> (-0.68%) ⬇️
python 57.20% <69.38%> (-25.59%) ⬇️
sqlite ?
unit 49.98% <65.30%> (-0.18%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...art-controls/src/operators/contributionOperator.ts 100.00% <ø> (ø)
...ui-chart-controls/src/operators/flattenOperator.ts 100.00% <ø> (ø)
...ui-chart-controls/src/operators/prophetOperator.ts 100.00% <ø> (ø)
...i-chart-controls/src/operators/resampleOperator.ts 100.00% <ø> (ø)
...ui-core/src/chart/components/FallbackComponent.tsx 100.00% <ø> (ø)
...ackages/superset-ui-core/src/query/api/v1/types.ts 100.00% <ø> (ø)
.../superset-ui-core/src/query/types/QueryFormData.ts 100.00% <ø> (ø)
...set-ui-core/src/ui-overrides/UiOverrideRegistry.ts 100.00% <ø> (ø)
...s/legacy-plugin-chart-calendar/src/controlPanel.ts 50.00% <0.00%> (-50.00%) ⬇️
...gins/legacy-plugin-chart-chord/src/controlPanel.ts 25.00% <0.00%> (-75.00%) ⬇️
... and 569 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 18b6fa1...be70356. Read the comment docs.

@AAfghahi AAfghahi force-pushed the arash/pylint_errors branch from be70356 to aa2756e Compare July 5, 2022 16:40
@hughhhh hughhhh merged commit ebdfcf0 into chart-power-query Jul 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants