changed the default value for buildQuery to null (apache-superset#40)

preset-io · Nov 20, 2018 · c87e6ac · c87e6ac
1 parent f73f38a
commit c87e6ac
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/packages/superset-ui-chart/src/models/ChartPlugin.js b/packages/superset-ui-chart/src/models/ChartPlugin.js
@@ -11,7 +11,7 @@ export default class ChartPlugin extends Plugin {
     metadata = isRequired('metadata'),
 
     // use buildQuery for immediate value
-    buildQuery = IDENTITY,
+    buildQuery,
     // use loadBuildQuery for dynamic import (lazy-loading)
     loadBuildQuery,
 
@@ -27,7 +27,7 @@ export default class ChartPlugin extends Plugin {
   } = {}) {
     super();
     this.metadata = metadata;
-    this.loadBuildQuery = loadBuildQuery || (() => buildQuery);
+    this.loadBuildQuery = loadBuildQuery || (buildQuery ? () => buildQuery : null);
     this.loadTransformProps = loadTransformProps || (() => transformProps);
 
     if (loadChart) {

diff --git a/packages/superset-ui-chart/test/models/ChartPlugin.test.js b/packages/superset-ui-chart/test/models/ChartPlugin.test.js
@@ -26,7 +26,7 @@ describe('ChartPlugin', () => {
           metadata,
           Chart: 'test',
         });
-        expect(plugin.loadBuildQuery()(FORM_DATA)).toBe(FORM_DATA);
+        expect(plugin.loadBuildQuery).toBeNull();
       });
       it('uses loadBuildQuery field if specified', () => {
         const plugin = new ChartPlugin({