chore(dbt Core): Bypass metric evaluation if final SQL is provided #305
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The CLI currently uses MetricFlow to retrieve the syntax for a metric. This current process has two issues:
mf
command can take a few minutes for each metric (causing a full sync to take a long time)mf
command might return a SQL query with un-necessaryJOIN
s that is not compatible with dataset metrics in Superset.To workaround this issue, this PR adds support for specifying the metric SQL syntax that should be used in Superset directly in
metric.meta.superset.expression
. In this case, since the metric won't be evaluated it's also required to specify themetric.meta.superset.model
(so that the CLI knows which dataset to associate the metric):