Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(sync native): Attempt to get the DB connection UUIDs via API #284

Merged
merged 2 commits into from
Apr 16, 2024

Conversation

Vitor-Avila
Copy link
Contributor

During the sync native command, the CLI has to identify all existing DB connections in the target instance/Workspace (and their corresponding UUIDs). This is currently achieved by exporting each DB connection, and getting the uuid from the YAML file.

This process was adopted because the uuid is not exposed in the API response for older Superset versions. However, it affects performance for two reasons:

  • Each DB connection is exported (the more connections created, the longer it would take).
  • There was a change in Superset that exporting a DB connection also includes all datasets, which can take time for connections with hundreds/thousands of datasets.

This PR defaults the process to get the uuid from the API response, and fallback in the old approach in case the API response doesn't have the uuid field.

Copy link
Member

@betodealmeida betodealmeida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ohhh, nice!

@Vitor-Avila Vitor-Avila merged commit b0fd1ce into main Apr 16, 2024
5 checks passed
@Vitor-Avila Vitor-Avila deleted the improve-override branch April 16, 2024 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants