fix(sqlglot): Convert metric syntax back to dialect-specific after parsing it #273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The CLI uses
sqlglotto parse SQL syntax from dbt metrics. While we were specifying the SQL dialect when parsing the query, we were not specifying the dialect when converting the parsed result back to SQL, which would cause issues with engine-specific syntaxes. Some examples:IF()statement would get converted toCASE(would still work but different syntax)DATE_DIFF()would get converted toDATEDIFF()which doesn't work with BQ.