Superset 3.0.0 Compatibility Proof-of-Concept #246
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliverlambson
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
Superceeded by #267
As per #244, the
superset-clicommand appears to be incompatible with Superset 3.0.0.In running superset-cli with loglevel=debug, this seems to be to due redirects causing some weirdness with the Auth header. See my post on that issue for the logs: #244 (comment).
I don't know a lot about http or redirects, but I knew I could prevent them by modifying the generated request URLs to exactly match the Superset API docs—this is because the
yarl.URL()constructor removes all trailing/, which are specified in the Superset docs. (e.g./api/v1/database?q=...will redirect to/api/v1/database/?q=...)I don't know if this is the real fix (using the exact endpoints as defined in the superset docs) or if the fix would be to continue relying on redirects and fixing that somehow?