c/c++ alternative delims

[cridemichel]

Dear developers,
first of all thank you very much for the very nice and useful plugin!
I have a minor issue to report.
To reproduce the issue, do the following steps:

- select in c/c++ the alternate delims '//' by using <leader>ca 
- select several lines in visual mode, e.g.

printf("one\n");
printf("two\n");
printf("three\n");

- comment these lines by using <leader>cc

what I get is the following:

  /* printf("one\n"); */
  // printf("two\n");
  /* printf("three\n"); */

while I expected the following output:

  // printf("one\n");
  // printf("two\n");
  // printf("three\n");

kind regards Cristiano

[alerque]

I agree something doesn't look right there!

We'd be happy to accept a PR that fixed this if anybody wants to tackle it!

[VishalNayek]

Hi! I am up for the challenge. You can assign this to me.

[VishalNayek]

Can you help me on how to actually run the source code, I am a bit stuck!

[alerque]

@VishalNayek Sure, but I'm not sure what you mean. If you have the plugin installed somewhere you should be able to just edit the plugin code wherever you already have it installed, then rerun vim to use your changes.

[cridemichel]

Hi, any chance to have it fixed?

[cridemichel]

it seems that a possible fix is rather easy, in file plugin/NERD_commenter.vim
inside the function s:CommentBlock, the following if...endif statement

 if !s:Multipart() && g:NERDAllowAnyVisualDelims && s:AltMultipart()
        let switchedDelims = 1
        call s:SwitchToAlternativeDelimiters(0)
    endif

should be replaced with

 if !s:Multipart() && !g:NERDAllowAnyVisualDelims && s:AltMultipart()
        let switchedDelims = 1
        call s:SwitchToAlternativeDelimiters(0)
    endif

since the switch to alternative delimiters there
should occur only if g:NERDAllowAnyVisualDelims = 0

Do you need a pull request or could you apply this minor change yourself?

best Cristiano

[alerque]

@cridemichel A PR would be easier for others to test!

[cridemichel]

I have just created a PR
best C.

[cridemichel]

Dear alerque,
is there any chance to have it merged into master?
best Cristiano

[alerque]

Hey thanks for the poke, I must have missed notification(s) in late October because I don't recall seeing that PR #440 at all. It looks quite reasonable to me and I've gone ahead and merged it.

[cridemichel]

thank you for the prompt reply! best C. Cristiano De Michele [email protected]

…

Il giorno 3 dic 2020, alle ore 10:34, Caleb Maclennan ***@***.***> ha scritto: Closed #425 <#425>. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#425 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ADU4YGQV7EPW5EYZJWFALF3SS5LT5ANCNFSM4MYTCSJA>.

[cridemichel]

Hi,
this issue is back and I have submitted a new pull request (#480) to fix it
please give a look at it when you have a chance,
best Cristiano