Updated param name in createAuthProvider() #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The providerName should be used in the creation of the provider instead of the provider itself
Current coverage is 63.98% (diff: 100%)@@ master #11 diff @@
==========================================
Files 14 14
Lines 908 908
Methods 101 101
Messages 0 0
Branches 149 149
==========================================
Hits 581 581
Misses 327 327
Partials 0 0
|
|
Great catch! Not sure why it wasn't caught by unit tests. Will release an update later today with the changes included. |
Merged
prescottprue
added a commit
that referenced
this pull request
Nov 23, 2016
* errors now dispatched for all query `.catch` methods * includes authProvider bug fix in #11 * Provider name validity checking (only Google, Twitter, Facebook, and Github) * Tests + Coverage improved with spies using `sinon` and `sinon-chai`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The providerName should be used in the creation of the provider instead of the provider itself