feat(core): keyboard accessibility support (on by default) #18
Comments
|
Love the idea, thanks for reporting! It would be cool to enable/disable that as well. Open to a PR if you get a chance, otherwise, I will try to get to it this week. |
prescottprue
changed the title
|
@prescottprue Yes definitely, users shouldn’t be able to focus this button if it’s disabled imo. Btw why doesn’t it use as a wrapper? |
|
Not sure what you mean by "why doesn't it use as a wrapper" - guessing you mean something why not support using it as a Higher Order Component wrapper? If so, the answer is just that I haven't needed it yet, but totally open to the idea. We could instead do a component prop similar to how material-ui does their button, it may be more clear than an HOC. |
|
@prescottprue Aha! Formatting removed a word, it was meant to be “why doesn’t it use |
|
Hi @prescottprue, did you have time to look into this? Thanks! |
* feat(core): keyboard accessibility support (on by default) - #18
* feat(core): keyboard accessibility support (on by default) - #18 * feat(deps): update prettier, istanbul, and mocha
|
@lmenus totally forgot about this, thanks for the reminder. Let me know if it doesn't work as you expect, and we can change it before it goes out to Was going to look into a few more changes before releasing |
|
Hi @prescottprue, sorry for the late reply. Tested it now and works great, thank you! |
* feat(ci): switch to Github Actions in place of TravisCI Also, changes from v0.6.0 all pre-releases including: * feat(core): keyboard accessibility support (on by default) - #18 * fix(core): prevent button text from being selected - @RabidFire * feat(deps): switch to yarn * feat(core): update to babel 7 and webpack 4 * chore(deps): switch to nyc over istanbul * chore(deps): update eslint, eslint-config-standard, prettier, mocha, and other dev dependencies
Hello, I think it would be great if this button was accessible using the keyboard. This can be achieved by adding
tabindex="0"androle="button"to the wrapper<div>tag that has click listener attached to it.The text was updated successfully, but these errors were encountered: