[yugabyte#18903] Use Clang 16 for the release build

Summary: Use Clang 16 for the release build. Performance testing comparing Clang 15 vs Clang 16 (as of commit c781baf) shows that there is no significant change. Test Plan: Jenkins Reviewers: steve.varnau, sagarwal Reviewed By: steve.varnau Differential Revision: https://phorge.dev.yugabyte.com/D28150
premkumr · Aug 29, 2023 · de44d6f · de44d6f
1 parent 28115bb
commit de44d6f
Show file tree

Hide file tree

Showing 5 changed files with 16 additions and 20 deletions.
diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
@@ -41,21 +41,21 @@ jobs:
       fail-fast: false
       matrix:
         include:
-          - name: "Clang 15, debug, CentOS 7"
+          - name: "Clang 16, debug, CentOS 7"
             os: ubuntu-20.04
-            yb_build_args: --clang15 debug --no-linuxbrew
+            yb_build_args: --clang16 debug --no-linuxbrew
 
-          - name: "Clang 15, fastdebug, CentOS 7"
+          - name: "Clang 16, fastdebug, CentOS 7"
             os: ubuntu-20.04
-            yb_build_args: --clang15 fastdebug --no-linuxbrew
+            yb_build_args: --clang16 fastdebug --no-linuxbrew
 
-          - name: "Clang 15, release, CentOS 7"
+          - name: "Clang 16, release, CentOS 7"
             os: ubuntu-20.04
-            yb_build_args: --clang15 release --no-linuxbrew
+            yb_build_args: --clang16 release --no-linuxbrew
 
-          - name: "Clang 15, release, CentOS 7, Linuxbrew glibc"
+          - name: "Clang 16, release, CentOS 7, Linuxbrew glibc"
             os: ubuntu-20.04
-            yb_build_args: --clang15 release --linuxbrew
+            yb_build_args: --clang16 release --linuxbrew
 
           - name: "GCC 11, debug, CentOS 7"
             os: ubuntu-20.04

diff --git a/build-support/common-build-env-test.sh b/build-support/common-build-env-test.sh
@@ -186,8 +186,8 @@ test_set_cmake_build_type_and_compiler_type   release    linux-gnu gcc        re
 test_set_cmake_build_type_and_compiler_type   release    linux-gnu gcc11      release    gcc11   0
 test_set_cmake_build_type_and_compiler_type   debug      linux-gnu auto       debug      clang16 0
 test_set_cmake_build_type_and_compiler_type   FaStDeBuG  linux-gnu auto       fastdebug  clang16 0
-test_set_cmake_build_type_and_compiler_type   release    linux-gnu auto       release    clang15 0
-test_set_cmake_build_type_and_compiler_type   tsan       linux-gnu auto       fastdebug  clang15 0
+test_set_cmake_build_type_and_compiler_type   release    linux-gnu auto       release    clang16 0
+test_set_cmake_build_type_and_compiler_type   tsan       linux-gnu auto       fastdebug  clang16 0
 test_set_cmake_build_type_and_compiler_type   asan       linux-gnu auto       fastdebug  clang16 0
 
 # -------------------------------------------------------------------------------------------------

diff --git a/build-support/common-build-env.sh b/build-support/common-build-env.sh
@@ -232,6 +232,7 @@ readonly -a VALID_COMPILER_TYPES=(
   clang14
   clang15
   clang16
+  clang17
 )
 make_regex_from_list VALID_COMPILER_TYPES "${VALID_COMPILER_TYPES[@]}"
 
@@ -544,12 +545,7 @@ set_default_compiler_type() {
       adjust_compiler_type_on_mac
     elif [[ $OSTYPE =~ ^linux ]]; then
       detect_architecture
-      if [[ ${build_type} =~ ^(asan|debug|fastdebug)$ ]]; then
-        YB_COMPILER_TYPE=clang16
-      else
-        # Use Clang 15 for release builds and TSAN builds until perf evaluation and TSAN fixes.
-        YB_COMPILER_TYPE=clang15
-      fi
+      YB_COMPILER_TYPE=clang16
     else
       fatal "Cannot set default compiler type on OS $OSTYPE"
     fi

diff --git a/build-support/tserver_lto.sh b/build-support/tserver_lto.sh
@@ -24,7 +24,7 @@ else
 fi
 
 if [[ $( uname -m ) == "x86_64" ]]; then
-  build_root_basename="$build_type-clang15-linuxbrew-full-lto-ninja"
+  build_root_basename="$build_type-clang16-linuxbrew-full-lto-ninja"
 fi
 
 dep_graph_cmd=(

diff --git a/jenkins_jobs.yml b/jenkins_jobs.yml
@@ -17,12 +17,12 @@ jobs:
     release_artifact: false
 
   - os: alma8
-    compiler: clang15
+    compiler: clang16
     build_type: release
     release_artifact: true
 
   - os: alma8
-    compiler: clang15
+    compiler: clang16
     build_type: release
     architecture: aarch64
     release_artifact: true
@@ -51,6 +51,6 @@ jobs:
     release_artifact: true
 
   - os: ubuntu20.04
-    compiler: clang15
+    compiler: clang16
     build_type: debug
     release_artifact: false