Fix visibility setting on android and gcc VS #2335
Open
+2
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit d363e35 broke visibility by not updating internal code to use new location
What does this PR do?
Fixes the
visibilitysetting for android and gcc VS projects (untested for gcc VS, just noticed it used the same old location forvisibility)How does this PR change Premake's behavior?
Doesn't error anymore
Anything else we should know?
Wanted to add a unit test but no idea in which file to add it
Did you check all the boxes?
closes #XXXXin comment to auto-close issue when PR is merged)