Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add: handle edge cases & tests for macos #477

Merged
merged 1 commit into from
Nov 3, 2023

Conversation

swarnimarun
Copy link
Contributor

Tests currently would only run on macos, but since we don't have a CI it shouldn't be an issue, when we add a CI we should support linux and other platforms as well for these tests.

@swarnimarun
Copy link
Contributor Author

@biswaroop1547 r?

@biswaroop1547
Copy link
Contributor

lgtm! also works for previously failing case i.e:

{"aarch64-apple-darwin": None, "universal-apple-darwin": Some("xyz.com"), "x86_64-apple-darwin": None}

@swarnimarun
Copy link
Contributor Author

@tiero merge?

@tiero
Copy link
Contributor

tiero commented Nov 3, 2023

utACK 65b7ebf

@tiero tiero merged commit a55b2ea into prem-research:main Nov 3, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants