Remove reflection from methods selection

preiter93 · Sep 28, 2024 · 547a9ef · 547a9ef
1 parent 2663e59
commit 547a9ef
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 20 deletions.
diff --git a/wireman/src/events/selection/methods.rs b/wireman/src/events/selection/methods.rs
@@ -13,7 +13,6 @@ pub enum MethodsSelectionEvents {
     Unselect,
     ClearSearch,
     GoToServices,
-    Reflection,
 }
 
 impl fmt::Display for MethodsSelectionEvents {
@@ -28,7 +27,6 @@ impl fmt::Display for MethodsSelectionEvents {
             MethodsSelectionEvents::Unselect => "Unselect",
             MethodsSelectionEvents::ClearSearch => "Clear Search",
             MethodsSelectionEvents::GoToServices => "Go to Services",
-            MethodsSelectionEvents::Reflection => "Switch to Reflection Mode",
         };
         write!(f, "{display_str}")
     }
@@ -88,19 +86,13 @@ impl EventHandler for MethodsSelectionEventsHandler {
             MethodsSelectionEvents::GoToServices => {
                 ctx.selection_tab = SelectionTab::Services;
             }
-            MethodsSelectionEvents::Reflection => {
-                ctx.selection.borrow_mut().toggle_reflection_mode();
-            }
         }
     }
 
     fn key_event_mappings(ctx: &Self::Context) -> Vec<(KeyEvent, MethodsSelectionEvents)> {
         let method_selected = ctx.selection.borrow().selected_method().is_some();
         let filter_active = ctx.selection.borrow_mut().methods_filter.is_some();
-        let mut map = vec![(
-            KeyEvent::ctrl(KeyCode::Char('r')),
-            MethodsSelectionEvents::Reflection,
-        )];
+        let mut map = vec![];
         if method_selected {
             map.extend([
                 (

diff --git a/wireman/src/model/core_client.rs b/wireman/src/model/core_client.rs
@@ -55,16 +55,6 @@ impl CoreClient {
         Ok(())
     }
 
-    // pub async fn reflect(host: &str) -> Option<ProtoDescriptor> {
-    //     match ProtoDescriptor::reflect(host).await {
-    //         Ok(desc) => Some(desc),
-    //         Err(err) => {
-    //             Logger::critical(format!("server reflection failed: {err}"));
-    //             None
-    //         }
-    //     }
-    // }
-
     /// Return the proto Services
     pub fn get_services(&self) -> Vec<ServiceDescriptor> {
         self.desc.get_services()

diff --git a/wireman/src/view/selection.rs b/wireman/src/view/selection.rs
@@ -151,7 +151,7 @@ impl Widget for SelectionPage<'_> {
         }
 
         // Show a dialog with address and authentication input fields
-        // which are required before server reflection
+        // which are required for server reflection
         if self.model.selection_mode == SelectionMode::ReflectionDialog {
             let popup_area = centered_rect(80, 80, area);
             Clear.render(popup_area, buf);