Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add windows, macos, linux and unix to targets #832

Merged
merged 4 commits into from
Feb 23, 2024

Conversation

wolfv
Copy link
Member

@wolfv wolfv commented Feb 22, 2024

I added a few more targets that should make it easier to select packages for some sets of platforms.

You can now do:

[target.unix.dependencies]
special-unix-pkg = "*"

[target.windows.dependencies]
pywin32 = "3.12"

# ... linux and macos are also available.

We could consider to overload osx, too. The correct name for osx is macOS though, since a while. Unfortunately that is not reflected in the "subdir" name.

@wolfv wolfv changed the title add windows, macos, linux and unix to targets feat" add windows, macos, linux and unix to targets Feb 22, 2024
@wolfv wolfv changed the title feat" add windows, macos, linux and unix to targets feat: add windows, macos, linux and unix to targets Feb 22, 2024
Copy link
Contributor

@ruben-arts ruben-arts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, If you add some tests and documentation we can merge it!

@ruben-arts
Copy link
Contributor

First thing i tried was pixi add --platform unix pytest which doesn't use this target selector. Might be nice to use that there aswell.

@wolfv
Copy link
Member Author

wolfv commented Feb 23, 2024

It takes me more than 5 minutes to get this done, so let's merge & file a new issue?

@ruben-arts ruben-arts enabled auto-merge (squash) February 23, 2024 15:39
@ruben-arts ruben-arts disabled auto-merge February 23, 2024 15:39
@ruben-arts ruben-arts merged commit 4b4fa86 into prefix-dev:main Feb 23, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants