Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update the PATH env var with dynamic elements #2541

Merged
merged 12 commits into from
Nov 25, 2024

Conversation

wolfv
Copy link
Member

@wolfv wolfv commented Nov 22, 2024

This should prepend any new PATH elements that were added after the pixi global install was performed to the PATH.

Copy link
Contributor

@nichmor nichmor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good! Let's add also a test for this

crates/pixi_trampoline/src/main.rs Outdated Show resolved Hide resolved
crates/pixi_trampoline/src/main.rs Outdated Show resolved Hide resolved
Copy link
Contributor

@nichmor nichmor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@Hofer-Julian Hofer-Julian merged commit aa93dfe into prefix-dev:main Nov 25, 2024
48 checks passed
@wolfv wolfv deleted the trampoline-dynamic-path branch November 25, 2024 10:10
@wolfv
Copy link
Member Author

wolfv commented Nov 25, 2024

Awesome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants