feat: add pixi-build behind preview feature #2514
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baszalmstra
approved these changes
Nov 19, 2024
ruben-arts
reviewed
Nov 19, 2024
Co-authored-by: Ruben Arts <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR gates the pixi-build feature behind the recently introduced preview features. This requires the
pixi-buildpreview feature to be enabled and this is checked on validation. We've decided on this name with @ruben-arts, but I'm fine changing it if we dont like it.I thought adding in validation would be the way to go, curious to know if this would miss anything,
Tests
A couple of automated test have been added to the manifest so that we can check if we properly error when either the
[build]or a source dependency is used in any feature/platform combination.cc @nichmor