fix: should now use the activated environment when running a task #1461
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baszalmstra
approved these changes
May 30, 2024
ruben-arts
reviewed
May 30, 2024
src/cli/run.rs
Outdated
| .map(|n| EnvironmentName::from_str(n.as_str())) | ||
| .transpose()? | ||
| .map(|n| { | ||
| let env_name = EnvironmentName::from_arg_or_env_var(args.environment).into_diagnostic()?; |
There was a problem hiding this comment.
isn't it possible to do this:
let explicit_environment = project.environment_from_name_or_env_var(args.environment)?;There was a problem hiding this comment.
Now all tools that use this function also warn the user at the end that it was used:
Project::warn_on_discovered_from_env(args.manifest_path.as_deref());There was a problem hiding this comment.
For 1) changed, 2) that warning seems to be there?
There was a problem hiding this comment.
Ah sorry didn't check as I assumed it was never added. This feels like a merge conflict fix.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the recently-added logic for figuring out the env name from an activated shell. Should fix: #1435