Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pixi.lock extras key should be ordered #791

Closed
2 tasks done
ismail opened this issue Feb 8, 2024 · 0 comments · Fixed by conda/rattler#540
Closed
2 tasks done

pixi.lock extras key should be ordered #791

ismail opened this issue Feb 8, 2024 · 0 comments · Fixed by conda/rattler#540
Assignees
@baszalmstra
Labels
🐞 bug Something isn't working 👋 good first issue Good for newcomers

Comments

@ismail
Copy link

ismail commented Feb 8, 2024 •
edited
Loading

Checks

  • I have checked that this issue has not already been reported.

  • I have confirmed this bug exists on the latest version of pixi, using pixi --version.

Reproducible example

For markdown_it_py from PyPi first I got the following in pixi.lock

         extras:
         - linkify
         - plugins

after a rm pixi.lock; pixi install I got

         extras:
         - plugins
         - linkify

This creates a no-op change for no good reason.
@ismail ismail added the 🐞 bug Something isn't working label Feb 8, 2024
@ruben-arts ruben-arts added the 👋 good first issue Good for newcomers label Feb 13, 2024
@baszalmstra baszalmstra self-assigned this Feb 23, 2024
@baszalmstra baszalmstra mentioned this issue Feb 23, 2024
Merged
baszalmstra added a commit to conda/rattler that referenced this issue Feb 26, 2024
@baszalmstra
feat: sort extras by name and urls by filename (#540)
53a29c6 
Sorts the extras according to name for consistency.

Also sorts the urls slightly different. Instead of sorting by the
complete url, now its first sorted by filename followed by the entire
url. This causes the urls to be sorted by package name most of the time
which reduces the diff if versions change.

Fixes prefix-dev/pixi#791
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@baszalmstra baszalmstra

Labels
🐞 bug Something isn't working 👋 good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: sort extras by name and urls by filename baszalmstra/rattler
3 participants
@ismail @baszalmstra @ruben-arts