Deprecate webdis and phpiredis #1179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tillkruss What are the purpose of this deprecation? This clients aren't useful and makes no sense to support? |
|
The phpiredis client hasn't been updated in years no and the author has stepped away from coding: https://github.com/nrk/phpiredis |
|
Is there any difference w/ and w/o phpiredis right now (before v3)? And just curious, what is expected to change with the Relay? |
|
You gotta benchmark that yourself if it makes sense for you workloads. Relay will drastically reduce the read IO when used with Predis. |
vladvildanov
added a commit
that referenced
this pull request
Apr 3, 2023
* Added support for new arguments for BITPOS, BITCOUNT commands (#1045) * Added support for new arguments for EXPIRE, EXPIREAT commands (#1046) * Extended core support by implementing SORT_RO command (#1044) * Added support for SORT_RO command * Codestyle fixes * Added command description --------- Co-authored-by: Vladyslav Vildanov <[email protected]> * fix deprecated call * Added support for container commands (#1049) * Added support for container commands FUNCTION LOAD, FUNCTION DELETE and FCALL * Changed ContainerInterface and AbstractContainer * Re-implement logic of abstract methods --------- Co-authored-by: Vladyslav Vildanov <[email protected]> * Added stream commands to KeyPrefixProcessor (#1051) Co-authored-by: Vladyslav Vildanov <[email protected]> * Fix return type of ReplicationInterface::getSlaves (#1111) * Codestyle fixes * Changed return annotation * Add option for disabling reads to slaves in replication topologies (#1168) * Add option for disabling reads to slaves in replication topologies (cherry picked from commit e132c31) * remove empty line --------- Co-authored-by: Till Krüss <[email protected]> * match `MasterSlaveReplication` (#1175) * match `MasterSlaveReplication` also the name of this method 😬 * Update SentinelReplication.php * Added CODEOWNERS file (#1181) * Added CODEOWNERS file * Update CODEOWNERS * Applied whole Redis commands path as @vladvildanov codeowner * Set @predis/team as Redis commands codeowners * Update CODEOWNERS --------- Co-authored-by: Vladyslav Vildanov <[email protected]> Co-authored-by: Till Krüss <[email protected]> * Deprecate webdis and phpiredis (#1179) * Deprecate webdis and phpiredis * remove space * tag v2.1.2 * Extended core support by implementing FCALL_RO command (#1191) * typo * Extended core support by implementing ACL SETUSER, GETUSER, DRYRUN (#1193) * Added support for ACL GETUSER, SETUSER, DRYRUN commands * Change test to support Redis > 6.0.0 * Removed selectors check * Add missing stream key prefixes (#1230) * Added missing stream key prefixes * Tested stream command key prefixing * Codestyle fix * Changed idx name for different index types --------- Co-authored-by: Vladyslav Vildanov <[email protected]> Co-authored-by: Till Krüss <[email protected]> Co-authored-by: Stephan <[email protected]> Co-authored-by: David Bomba <[email protected]> Co-authored-by: Till Krüss <[email protected]> Co-authored-by: Jess Archer <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will be replaced with Relay in v3.0.
See #1084.