Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wrong aggregation of shap values #52

Merged
merged 3 commits into from
May 2, 2024
Merged

Fix wrong aggregation of shap values #52

merged 3 commits into from
May 2, 2024

Conversation

jvdd
Copy link
Member

@jvdd jvdd commented May 2, 2024

Fix a bug introduced in #49

@jvdd
Copy link
Member Author

jvdd commented May 2, 2024

Fixes bug introduced in this line #49 (comment)

Copy link
Member

@jonasvdd jonasvdd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jonasvdd
Copy link
Member

jonasvdd commented May 2, 2024

@jvdd, maybe just add a comment / sanity check on which dimensions you might expect
You could also include an assert regarding the dimensions

@JarneVerhaeghe JarneVerhaeghe merged commit c8208d8 into main May 2, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants