Correct use of random_state for xgboost #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The seed parameter in xgboost was changed to "random_state" to match sklearn's API. This fix corrects the random state behavior and silences a warning which prints on every iteration.
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #37 +/- ##
=======================================
Coverage 83.87% 83.87%
=======================================
Files 6 6
Lines 372 372
=======================================
Hits 312 312
Misses 60 60
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Thx for submitting this clear PR @lorenjan Always pleased to see the community contribute!! 🤝 |
jvdd
approved these changes
May 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The seed parameter in xgboost was changed to "random_state" to match sklearn's API. This fix corrects the random state behavior and silences a warning which prints on every iteration.