Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v202211.0.0 #50

Merged
merged 14 commits into from
Nov 22, 2022
Merged

Release v202211.0.0 #50

merged 14 commits into from
Nov 22, 2022

Conversation

MakisH
Copy link
Member

@MakisH MakisH commented Nov 18, 2022

Continuing with unreleased changes from #44.

New changes

  • Added ASTE and Julia bindings
  • Added dune-fem
  • Added the binaries of the elastic-tube-1d C++ solvers
  • Upgraded OpenFOAM to v2206, CalculiX to v2.20, and Nutils to v7.2 (with a special case for the perpendicular-flap/fluid-nutils tutorial case)
  • Added the Python pandas package
  • Replaced the PDF reader Evince with Atril, fixing an issue with opening URLs
  • Updated preCICE branch name (master->main)

Previously unreleased changes

  • Added libvirt support (experimental)
  • Updated a few CI-related things

MakisH and others added 4 commits November 18, 2022 15:32
* Add ASTE recipe for the latest ASTE release

* Add corresponding aste version

* Use branch name instead of version

Co-authored-by: Gerasimos Chourdakis <[email protected]>
Co-authored-by: Gerasimos Chourdakis <[email protected]>
Co-authored-by: Ishaan Desai <[email protected]>
Co-authored-by: Ishaan Desai <[email protected]>
@MakisH MakisH marked this pull request as ready for review November 18, 2022 14:37
@MakisH MakisH requested a review from fsimonis November 18, 2022 14:37
@MakisH MakisH self-assigned this Nov 18, 2022
@MakisH MakisH changed the title Develop Release v202211.0.0 Nov 18, 2022
@MakisH MakisH marked this pull request as draft November 18, 2022 15:39
@MakisH MakisH marked this pull request as ready for review November 18, 2022 15:39
@fsimonis
Copy link
Member

fsimonis commented Nov 21, 2022

aste-turbine: ❌
precice-aste-evaluate: command not found

channel-transport/fluid-nutils/run.sh: ❌

opened log at file:///home/vagrant/public_html/fluid.py/log-1.html
nutils v6.3 "garak-guksu"
start Mon Nov 21 11:22:59 2022
Running utils
ValueError: not a 'str': ['u']

channel-transport-reaction: ⭕

Super skewed though. fluid reaches t= 5/5 while the chemical part is still at t=1.25/5

elastic-tube-1d: python ⭕ (cpp untested)

elastic-tube-3d:
fluid-openfoam + solid-calculix ⭕ (plot displacements doesn't work though)
fluid-openfoam + solid-fenics ⭕

@MakisH MakisH marked this pull request as draft November 21, 2022 21:07
@MakisH MakisH marked this pull request as ready for review November 21, 2022 21:07
@MakisH
Copy link
Member Author

MakisH commented Nov 21, 2022

@fsimonis thanks for testing! I fixed several issues (including the aste and nutils) and restarted the build.

Super skewed though. fluid reaches t= 5/5 while the chemical part is still at t=1.25/5

This is fine, right? It is a uni-directional coupling.

elastic-tube-3d:
fluid-openfoam + solid-calculix ⭕ (plot displacements doesn't work though)

What is the error you get? Did you run both cases before running the plotting script? In any case, this would be something for the tutorials.

fluid-openfoam + solid-fenics ⭕

The solid-fenics case does not seem to work for me, at least in my now modified VM (which should not have anything relevant):

vagrant@precicevm:~/tutorials/elastic-tube-3d/solid-fenics$ ./run.sh 
Traceback (most recent call last):
  File "solid.py", line 2, in <module>
    from fenics import Constant, Function, AutoSubDomain, VectorFunctionSpace, interpolate, \
  File "/usr/lib/python3/dist-packages/fenics/__init__.py", line 7, in <module>
    from dolfin import *
  File "/usr/lib/petsc/lib/python3/dist-packages/dolfin/__init__.py", line 144, in <module>
    from .fem.assembling import (assemble, assemble_system, assemble_multimesh, assemble_mixed,
  File "/usr/lib/petsc/lib/python3/dist-packages/dolfin/fem/assembling.py", line 38, in <module>
    from ufl.form import sub_forms_by_domain
ImportError: cannot import name 'sub_forms_by_domain' from 'ufl.form' (/home/vagrant/.local/lib/python3.8/site-packages/ufl/form.py)

This seems to be working in v2202, so, if you can reproduce it, it will be a regression.

(update: it seems to be running correctly in the original VM that you tried. I will wait for this build to complete to find out if solid-fenics still works in the VM.)

@MakisH
Copy link
Member Author

MakisH commented Nov 21, 2022

Regarding the plotting script, this does not seem to be a regression: #63

Update: It does not even seem to be an issue. @fsimonis please confirm.

@MakisH
Copy link
Member Author

MakisH commented Nov 22, 2022

With the latest build:

  • All FEniCS cases fail to start ❌, with the same error as in my previous comment. @IshaanDesai any clue why I may be getting this message? This is definitely a new VM issue now. Have a look at the recent commits as well.

Removing pandas did not help. Removing the aste directory from PATH did not help (maybe there was some metis conflict). Removing dune-fem did not help. Removing atril did not help. Removing nutils did not help. Removing python3.8-venv did not help. The only thing I can imagine is that installing python3.8-venv and starting a venv (which I have deactivated) messed up something.

Is maybe just FEniCS broken right now and I got a bad update?

vagrant@precicevm:~/tutorials/flow-over-heated-plate/solid-fenics$ ./run.sh 
No protocol specified
Traceback (most recent call last):
  File "solid.py", line 6, in <module>
    from fenics import Function, SubDomain, RectangleMesh, BoxMesh, FunctionSpace, VectorFunctionSpace, Point, \
  File "/usr/lib/python3/dist-packages/fenics/__init__.py", line 7, in <module>
    from dolfin import *
  File "/usr/lib/petsc/lib/python3/dist-packages/dolfin/__init__.py", line 144, in <module>
    from .fem.assembling import (assemble, assemble_system, assemble_multimesh, assemble_mixed,
  File "/usr/lib/petsc/lib/python3/dist-packages/dolfin/fem/assembling.py", line 38, in <module>
    from ufl.form import sub_forms_by_domain
ImportError: cannot import name 'sub_forms_by_domain' from 'ufl.form' (/home/vagrant/.local/lib/python3.8/site-packages/ufl/form.py)
  • aste-turbine completes 🟢
  • channel-transport Nutils cases start 🟢
  • flow-over-heated-plate/solid-dunefem starts 🟢
  • flow-over-heated-plate/solid-nutils starts 🟢
  • perpendicular-flap/fluid-nutils starts (with Nutils 6.3 automatically set) 🟢
  • the elastic-tube-1d C++ cases start 🟢
  • the plotting script of the oscillator works 🟢
  • URLs from PDF files open normally in Firefox 🟢

Other than FEniCS, I am triggering a new build to get the new tutorials, and this is ready.

@MakisH MakisH marked this pull request as draft November 22, 2022 00:34
@MakisH MakisH marked this pull request as ready for review November 22, 2022 00:34
@IshaanDesai
Copy link
Member

The error seen with FEniCS is a known issue and has been mentioned in the troubleshooting section of the fenics-adapter. I am trying to see if the solution written there also works for the vm, will open a PR if that is the case.

@MakisH MakisH marked this pull request as draft November 22, 2022 13:22
@MakisH MakisH marked this pull request as ready for review November 22, 2022 13:22
Investigating why it was previously giving a permission issue.
@MakisH MakisH marked this pull request as draft November 22, 2022 14:37
@MakisH MakisH marked this pull request as ready for review November 22, 2022 14:37
Copy link
Member

@IshaanDesai IshaanDesai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ran the FEniCS cases in a VM created from the artifact of https://github.com/precice/vm/actions/runs/3524369114 and the cases work.

@MakisH
Copy link
Member Author

MakisH commented Nov 22, 2022

I confirm that the FEniCS cases now also run. Thank you very much! 🤗

@MakisH MakisH merged commit 4996945 into main Nov 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants